FreeBSD Bugzilla – Attachment 180481 Details for
Bug 217391
[ipfw] [panic] erroneous ipfw rule triggers KASSERT
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
ipfw_check_subtype.diff (text/plain), 609 bytes, created by
Andrey V. Elsukov
on 2017-03-04 01:46:28 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Andrey V. Elsukov
Created:
2017-03-04 01:46:28 UTC
Size:
609 bytes
patch
obsolete
>diff --git a/sys/netpfil/ipfw/ip_fw_sockopt.c b/sys/netpfil/ipfw/ip_fw_sockopt.c >index 4a8ffaacbcf..6c8422f714c 100644 >--- a/sys/netpfil/ipfw/ip_fw_sockopt.c >+++ b/sys/netpfil/ipfw/ip_fw_sockopt.c >@@ -2669,7 +2669,14 @@ ref_opcode_object(struct ip_fw_chain *ch, ipfw_insn *cmd, struct tid_info *ti, > return (0); > } > >- /* Found. Bump refcount and update kidx. */ >+ /* >+ * Object is already exist. >+ * Its subtype should match with expected value. >+ */ >+ if (ti->type != no->subtype) >+ return (EINVAL); >+ >+ /* Bump refcount and update kidx. */ > no->refcnt++; > rw->update(cmd, no->kidx); > return (0);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=180481">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 217391
: 180481