Attachment 183069 Details for Bug 218187 – Updated patch.

[patch] Updated patch.

qt5-gold.diff (text/plain), 2.45 KB, created by Tobias C. Berner on 2017-05-30 13:37:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tobias C. Berner

Created: 2017-05-30 13:37:38 UTC

Size: 2.45 KB

patch

obsolete

>Index: Mk/bsd.qt.mk
>===================================================================
>--- Mk/bsd.qt.mk	(revision 442062)
>+++ Mk/bsd.qt.mk	(working copy)
>@@ -147,7 +147,9 @@
> .  if ${ARCH} == i386 && empty(MACHINE_CPU:Msse2)
> CONFIGURE_ARGS+=-no-sse2
> .  endif
>-
>+# Work around a bug in current binutils, where the gold linker creates
>+# duplicate symbols. See pr 218187. Disable the gold-linker for Qt5 ports.
>+CONFIGURE_ARGS+=	-no-use-gold-linker
> . endif
> 
> . if defined(WANT_QT_DEBUG) || defined(WITH_DEBUG)
>Index: UPDATING
>===================================================================
>--- UPDATING	(revision 442062)
>+++ UPDATING	(working copy)
>@@ -5,6 +5,27 @@
> You should get into the habit of checking this file for changes each time
> you update your ports collection, before attempting any port upgrades.
> 
>+20170530:
>+  AFFECTS: users of Qt 5 in presence of binutils
>+  AUTHOR: amdmi3@FreeBSD.org
>+
>+  gold linker from binutils 2.28 may produce duplicate library
>+  symbols, which makes shared libraries created with it not usable
>+  with conventional ld linker.
>+
>+  This affects Qt, as qt5-qmake will detect gold and use it to build
>+  Qt libraries. Broken libQt5Core will be produced and ports which
>+  depend on it will then fail to link with the following errors:
>+
>+    ...lib/libQt5Core.so:(.dynamic+0x27ac8): multiple definition of `__bss_start at Qt_5'
>+    ...lib/libQt5Core.so:(.dynamic+0x27ac8): first defined here
>+    ...lib/libQt5Core.so:(.dynamic+0x27ac8): multiple definition of `_edata at Qt_5'
>+    ...lib/libQt5Core.so:(.dynamic+0x27ac8): first defined here
>+    ...lib/libQt5Core.so:(.dynamic+0x2b2d0): multiple definition of `_end at Qt_5'
>+
>+  Qt5 was fixed to ignore gold. If you see these errors, you
>+  need to rebuild qt5-qmake, then all qt5-* ports.
>+
> 20170529:
>   AFFECTS: users of sysutils/dsbmd
>   AUTHOR: mk@freeshell.de
>Index: devel/qt5-core/Makefile
>===================================================================
>--- devel/qt5-core/Makefile	(revision 442062)
>+++ devel/qt5-core/Makefile	(working copy)
>@@ -2,6 +2,7 @@
> 
> PORTNAME=	core
> DISTVERSION=	${QT5_VERSION}
>+PORTREVISION=	1
> CATEGORIES=	devel
> PKGNAMEPREFIX=	qt5-
> 
>Index: devel/qt5-qmake/Makefile
>===================================================================
>--- devel/qt5-qmake/Makefile	(revision 442062)
>+++ devel/qt5-qmake/Makefile	(working copy)
>@@ -2,7 +2,7 @@
> 
> PORTNAME=	qmake
> DISTVERSION=	${QT5_VERSION}
>-PORTREVISION=	2
>+PORTREVISION=	3
> CATEGORIES=	devel
> PKGNAMEPREFIX=	qt5-
>

Flags:

rakuco: maintainer-approval+

Actions: View | Diff

Attachments on bug 218187: 181269 | 181271 | 181488 | 183069