Attachment 183511 Details for Bug 219800 – proposed fix for cursor-visibility

[patch] proposed fix for cursor-visibility

xterm-cursor.diff (text/plain), 1.17 KB, created by Thomas E. Dickey on 2017-06-15 22:41:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas E. Dickey

Created: 2017-06-15 22:41:07 UTC

Size: 1.17 KB

patch

obsolete

>--- charproc.c	2017/06/12 22:00:15	1.1488
>+++ charproc.c	2017/06/15 21:45:43
>@@ -10354,10 +10354,16 @@
> 		}
> 	    }
> 	}
>-	if (T_COLOR(screen, TEXT_CURSOR) == bg_pix ||
>-	    T_COLOR(screen, TEXT_CURSOR) == (reversed
>-					     ? xw->dft_background
>-					     : xw->dft_foreground)) {
>+
>+#define CUR_XX T_COLOR(screen, TEXT_CURSOR)
>+#define CGS_FG getCgsFore(xw, currentWin, getCgsGC(xw, currentWin, currentCgs))
>+#define CGS_BG getCgsBack(xw, currentWin, getCgsGC(xw, currentWin, currentCgs))
>+
>+#define FIX_311 (CUR_XX == (reversed ? xw->dft_background : xw->dft_foreground))
>+#define FIX_328 (CUR_XX == bg_pix)
>+#define FIX_330 (FIX_328 && reversed && in_selection)
>+
>+	if (FIX_330 || FIX_311) {
> 	    setCgsBack(xw, currentWin, currentCgs, fg_pix);
> 	}
> 	setCgsFore(xw, currentWin, currentCgs, bg_pix);
>@@ -10434,10 +10440,7 @@
> 	     * Set up a new request.
> 	     */
> 	    if (filled) {
>-		if (T_COLOR(screen, TEXT_CURSOR) == bg_pix ||
>-		    T_COLOR(screen, TEXT_CURSOR) == (reversed
>-						     ? xw->dft_background
>-						     : xw->dft_foreground)) {
>+		if (FIX_330 || FIX_311) {
> 		    setCgsBack(xw, currentWin, currentCgs, fg_pix);
> 		}
> 		setCgsFore(xw, currentWin, currentCgs, bg_pix);

Actions: View | Diff

Attachments on bug 219800: 183269 | 183270 | 183341 | 183511 | 183559 | 183574