Attachment 185809 Details for Bug 221853 – sysctl_(add|register)_oid(): Prefix log message with the function name

[patch] sysctl_(add|register)_oid(): Prefix log message with the function name

sysctl-Prefix-log-messages-with-the-function-name.diff (text/plain), 1.55 KB, created by Fabian Keil on 2017-08-27 10:33:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fabian Keil

Created: 2017-08-27 10:33:26 UTC

Size: 1.55 KB

patch

obsolete

>From 7e0e93f754c375b0842345a595a265a453708042 Mon Sep 17 00:00:00 2001
>From: Fabian Keil <fk@fabiankeil.de>
>Date: Mon, 7 Aug 2017 19:00:56 +0200
>Subject: [PATCH 1/2] sysctl_register_oid(): Prefix log message with the
> function name
>
>Obtained from: ElectroBSD
>---
> sys/kern/kern_sysctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/sys/kern/kern_sysctl.c b/sys/kern/kern_sysctl.c
>index 829f95568108..8282c2d91b04 100644
>--- a/sys/kern/kern_sysctl.c
>+++ b/sys/kern/kern_sysctl.c
>@@ -343,7 +343,8 @@ sysctl_register_oid(struct sysctl_oid *oidp)
> 			p->oid_refcnt++;
> 			return;
> 		} else {
>-			printf("can't re-use a leaf (%s)!\n", p->oid_name);
>+			printf("%s: can't re-use a leaf (%s)!\n",
>+			    __func__, p->oid_name);
> 			return;
> 		}
> 	}
>-- 
>2.14.1
>
>
>From 836f48e95ba31983e6e38473baf70b3c6a5bc5a0 Mon Sep 17 00:00:00 2001
>From: Fabian Keil <fk@fabiankeil.de>
>Date: Sat, 12 Aug 2017 12:33:46 +0200
>Subject: [PATCH 2/2] sysctl_add_oid(): Prefix log message with the function
> name
>
>Obtained from: ElectroBSD
>---
> sys/kern/kern_sysctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/sys/kern/kern_sysctl.c b/sys/kern/kern_sysctl.c
>index 8282c2d91b04..572122935e95 100644
>--- a/sys/kern/kern_sysctl.c
>+++ b/sys/kern/kern_sysctl.c
>@@ -713,7 +713,8 @@ sysctl_add_oid(struct sysctl_ctx_list *clist, struct sysctl_oid_list *parent,
> 			return (oidp);
> 		} else {
> 			SYSCTL_WUNLOCK();
>-			printf("can't re-use a leaf (%s)!\n", name);
>+			printf("%s: can't re-use a leaf (%s)!\n",
>+			    __func__, name);
> 			return (NULL);
> 		}
> 	}
>-- 
>2.14.1
>

Actions: View | Diff

Attachments on bug 221853: 185809