Attachment 185945 Details for Bug 221953 – cam iosched: Limit the quanta default to hz if it's below 200

[patch] cam iosched: Limit the quanta default to hz if it's below 200

0002-cam-iosched-Limit-the-quanta-default-to-hz-if-it-s-be.diff (text/plain), 1.19 KB, created by Fabian Keil on 2017-08-31 10:14:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fabian Keil

Created: 2017-08-31 10:14:21 UTC

Size: 1.19 KB

patch

obsolete

>From 858a9123428f6447b3a55d1b510b07876e2191be Mon Sep 17 00:00:00 2001
>From: Fabian Keil <fk@fabiankeil.de>
>Date: Wed, 16 Aug 2017 12:30:17 +0200
>Subject: [PATCH 2/8] cam iosched: Limit the quanta default to hz if it's below
> 200
>
>Previously the quanta default was 200 while hz defaults
>to 100 when running in a vm.
>
>The cam_iosched_ticker() can't be scheduled more than once per tick
>and some of the limiters depend on quanta matching the number of calls
>per second to enforce the proper limits.
>
>Obtained from: ElectroBSD
>---
> sys/cam/cam_iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/sys/cam/cam_iosched.c b/sys/cam/cam_iosched.c
>index 7ccc0a6911dd..079f579433ec 100644
>--- a/sys/cam/cam_iosched.c
>+++ b/sys/cam/cam_iosched.c
>@@ -1022,7 +1022,7 @@ cam_iosched_init(struct cam_iosched_softc **iscp, struct cam_periph *periph)
> 		bioq_init(&(*iscp)->write_queue);
> 		(*iscp)->read_bias = 100;
> 		(*iscp)->current_read_bias = 100;
>-		(*iscp)->quanta = 200;
>+		(*iscp)->quanta = min(hz, 200);
> 		cam_iosched_iop_stats_init(*iscp, &(*iscp)->read_stats);
> 		cam_iosched_iop_stats_init(*iscp, &(*iscp)->write_stats);
> 		cam_iosched_iop_stats_init(*iscp, &(*iscp)->trim_stats);
>-- 
>2.14.1
>

Actions: View | Diff

Attachments on bug 221953: 185945