Attachment 190984 Details for Bug 226135 – Use CPPFLAGS, Make CFLAGS comment more prominent

[patch] Use CPPFLAGS, Make CFLAGS comment more prominent

patch.patch (text/plain), 1.65 KB, created by Kubilay Kocak on 2018-02-25 07:38:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kubilay Kocak

Created: 2018-02-25 07:38:45 UTC

Size: 1.65 KB

patch

obsolete

>Index: Makefile
>===================================================================
>--- Makefile	(revision 462770)
>+++ Makefile	(working copy)
>@@ -2,7 +2,7 @@
> 
> PORTNAME=	python
> PORTVERSION=	${PYTHON_PORTVERSION}
>-PORTREVISION=	1
>+PORTREVISION=	2
> CATEGORIES=	lang python ipv6
> MASTER_SITES=	PYTHON/ftp/python/${PORTVERSION}
> PKGNAMESUFFIX=	27
>@@ -14,12 +14,21 @@
> 
> LICENSE=	PSFL
> 
>+# lang/python* ports use CPPFLAGS over CFLAGS due to multiple complex
>+# *FLAGS and include ordering bugs/issues in the Python build, that cause
>+# modules such as elementtree and pyexpat to fail to build, among other
>+# difficult to isolate issues. Do not add to or modify global variables
>+# unless the implications and pitfalls are completely understood.
>+# See: https://bugs.python.org/issue6299#msg210189
>+
> USES=		cpe ncurses pathfix pkgconfig readline:port shebangfix ssl tar:xz
> PATHFIX_MAKEFILEIN=	Makefile.pre.in
> USE_LDCONFIG=	yes
>-CFLAGS+=	-I${OPENSSLINC}
> GNU_CONFIGURE=	yes
>-LIBS+=		-L${OPENSSLLIB}
>+
>+CPPFLAGS+=      -I${OPENSSLINC}
>+LDFLAGS+=	-L${OPENSSLLIB}
>+
> python_CMD=	${PREFIX}/bin/python${PYTHON_PORTVERSION:R}
> SHEBANG_FILES=	Lib/lib2to3/pgen2/*.py Lib/lib2to3/tests/*.py Lib/lib2to3/tests/data/*.py \
> 		Lib/idlelib/*.py Lib/encodings/*.py Lib/test/*.py Lib/UserString.py \
>@@ -60,9 +69,6 @@
> LIBFFI_CONFIGURE_ON=	--with-system-ffi
> LIBFFI_LIB_DEPENDS=	libffi.so:devel/libffi
> 
>-# Use CPPFLAGS over CFLAGS due to -I ordering, causing elementtree and pyexpat
>-# to break in Python 2.7, or preprocessor complaints in Python >= 3.3
>-# Upstream Issue: https://bugs.python.org/issue6299
> NLS_USES=		gettext
> NLS_CPPFLAGS=		-I${LOCALBASE}/include
> NLS_LIBS=		-L${LOCALBASE}/lib -lintl

Actions: View | Diff

Attachments on bug 226135: 190911 | 190956 | 190984