Attachment 205155 Details for Bug 238636 – The patch file

[patch] The patch file

0001-dev-ath-fix-kernel-address-leakage-in-if_ath_sysctl.patch (text/plain), 2.02 KB, created by Fuqian on 2019-06-17 02:10:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fuqian

Created: 2019-06-17 02:10:16 UTC

Size: 2.02 KB

patch

obsolete

>From a7d5541341d85cdd159fcebab606c8d0072c55e0 Mon Sep 17 00:00:00 2001
>From: Fuqian Huang <huangfq.daxian@gmail.com>
>Date: Mon, 17 Jun 2019 10:06:48 +0800
>Subject: [PATCH] dev: ath: fix kernel address leakage in if_ath_sysctl.c
>
>In function ath_sysctl_txagg, some kernel addresses are printed out,
>make it only print out only when ATH_DEBUG is enabled.
>
>Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
>---
> sys/dev/ath/if_ath_sysctl.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
>diff --git a/sys/dev/ath/if_ath_sysctl.c b/sys/dev/ath/if_ath_sysctl.c
>index 3e4e4724635..c9fac910c13 100644
>--- a/sys/dev/ath/if_ath_sysctl.c
>+++ b/sys/dev/ath/if_ath_sysctl.c
>@@ -494,6 +494,7 @@ ath_sysctl_txagg(SYSCTL_HANDLER_ARGS)
> 
> 	for (i = 0; i < HAL_NUM_TX_QUEUES; i++) {
> 		if (ATH_TXQ_SETUP(sc, i)) {
>+#ifdef ATH_DEBUG
> 			printf("HW TXQ %d: axq_depth=%d, axq_aggr_depth=%d, "
> 			    "axq_fifo_depth=%d, holdingbf=%p\n",
> 			    i,
>@@ -501,6 +502,14 @@ ath_sysctl_txagg(SYSCTL_HANDLER_ARGS)
> 			    sc->sc_txq[i].axq_aggr_depth,
> 			    sc->sc_txq[i].axq_fifo_depth,
> 			    sc->sc_txq[i].axq_holdingbf);
>+#else
>+			printf("HW TXQ %d: axq_depth=%d, axq_aggr_depth=%d, "
>+			    "axq_fifo_depth=%d\n",
>+			    i,
>+			    sc->sc_txq[i].axq_depth,
>+			    sc->sc_txq[i].axq_aggr_depth,
>+			    sc->sc_txq[i].axq_fifo_depth);
>+#endif
> 		}
> 	}
> 
>@@ -532,6 +541,7 @@ ath_sysctl_txagg(SYSCTL_HANDLER_ARGS)
> 
> 	ATH_RX_LOCK(sc);
> 	for (i = 0; i < 2; i++) {
>+#ifdef ATH_DEBUG
> 		printf("%d: fifolen: %d/%d; head=%d; tail=%d; m_pending=%p, m_holdbf=%p\n",
> 		    i,
> 		    sc->sc_rxedma[i].m_fifo_depth,
>@@ -540,6 +550,14 @@ ath_sysctl_txagg(SYSCTL_HANDLER_ARGS)
> 		    sc->sc_rxedma[i].m_fifo_tail,
> 		    sc->sc_rxedma[i].m_rxpending,
> 		    sc->sc_rxedma[i].m_holdbf);
>+#else
>+		printf("%d: fifolen: %d/%d; head=%d; tail=%d;\n",
>+		    i,
>+		    sc->sc_rxedma[i].m_fifo_depth,
>+		    sc->sc_rxedma[i].m_fifolen,
>+		    sc->sc_rxedma[i].m_fifo_head,
>+		    sc->sc_rxedma[i].m_fifo_tail);
>+#endif
> 	}
> 	i = 0;
> 	TAILQ_FOREACH(bf, &sc->sc_rxbuf, bf_list) {
>-- 
>2.11.0
>

Actions: View | Diff

Attachments on bug 238636: 205155