FreeBSD Bugzilla – Attachment 217479 Details for
Bug 248869
e1000: unsolicited promisc mode during init (post iflib)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
flags fix
e1000-promisc.patch (text/plain), 924 bytes, created by
Franco Fichtner
on 2020-08-24 06:55:23 UTC
(
hide
)
Description:
flags fix
Filename:
MIME Type:
Creator:
Franco Fichtner
Created:
2020-08-24 06:55:23 UTC
Size:
924 bytes
patch
obsolete
>From 87fe5cb141fb6acb9ab00ad0497a3a2dfa2dbaea Mon Sep 17 00:00:00 2001 >From: Franco Fichtner <franco@opnsense.org> >Date: Thu, 20 Aug 2020 05:09:51 +0200 >Subject: [PATCH] e1000: properly retain promisc flag > >The iflib rewrite forced the promisc flag but it was not reported >to the system. Noticed on a stock VM that went into unsolicited >promisc mode when dhclient was started during bootup. >--- > sys/dev/e1000/if_em.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c >index 3db75524963..e3d4787787c 100644 >--- a/sys/dev/e1000/if_em.c >+++ b/sys/dev/e1000/if_em.c >@@ -1342,7 +1342,7 @@ em_if_init(if_ctx_t ctx) > } > > /* Don't lose promiscuous settings */ >- em_if_set_promisc(ctx, IFF_PROMISC); >+ em_if_set_promisc(ctx, if_getflags(ifp)); > e1000_clear_hw_cntrs_base_generic(&adapter->hw); > > /* MSI-X configuration for 82574 */ >-- >2.21.0 (Apple Git-122.2) >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=217479">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 248869
: 217479