Attachment 217764 Details for Bug 249126 – netdata-go.diff

[patch] netdata-go.diff

netdatago.diff (text/plain), 15.35 KB, created by Dries Michiels on 2020-09-05 12:14:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dries Michiels

Created: 2020-09-05 12:14:01 UTC

Size: 15.35 KB

patch

obsolete

>Index: net-mgmt/netdata-go/Makefile
>===================================================================
>--- net-mgmt/netdata-go/Makefile	(revision 547648)
>+++ net-mgmt/netdata-go/Makefile	(working copy)
>@@ -1,69 +1,72 @@
> # $FreeBSD$
> 
> PORTNAME=	netdata-go
> DISTVERSIONPREFIX=	v
>-DISTVERSION=	0.20.0
>+DISTVERSION=	0.21.0
> CATEGORIES=	net-mgmt
> 
> MAINTAINER=	driesm.michiels@gmail.com
> COMMENT=	External netdata collection plugin written in Go
> 
> LICENSE=	GPLv3
> LICENSE_FILE=	${WRKSRC}/LICENSE
> 
> USES=		go:modules
> 
> USE_GITHUB=	yes
> GH_ACCOUNT=	netdata
> GH_PROJECT=	go.d.plugin
>-GH_TUPLE=	DATA-DOG:go-sqlmock:v1.4.1:data_dog_go_sqlmock/vendor/github.com/DATA-DOG/go-sqlmock \
>+GH_TUPLE=	\
>+		DATA-DOG:go-sqlmock:v1.4.1:data_dog_go_sqlmock/vendor/github.com/DATA-DOG/go-sqlmock \
> 		Wing924:ltsv:v0.3.1:wing924_ltsv/vendor/github.com/Wing924/ltsv \
> 		axiomhq:hyperloglog:a4c4c47bc57f:axiomhq_hyperloglog/vendor/github.com/axiomhq/hyperloglog \
> 		cespare:xxhash:v1.1.0:cespare_xxhash/vendor/github.com/cespare/xxhash \
> 		cloudflare:cfssl:v1.4.1:cloudflare_cfssl/vendor/github.com/cloudflare/cfssl \
> 		davecgh:go-spew:v1.1.1:davecgh_go_spew/vendor/github.com/davecgh/go-spew \
> 		dgryski:go-metro:280f6062b5bc:dgryski_go_metro/vendor/github.com/dgryski/go-metro \
> 		fsnotify:fsnotify:v1.4.9:fsnotify_fsnotify/vendor/github.com/fsnotify/fsnotify \
>+		go-check:check:8fa46927fb4f:go_check_check/vendor/gopkg.in/check.v1 \
> 		go-ini:ini:v1.57.0:go_ini_ini/vendor/gopkg.in/ini.v1 \
> 		go-sql-driver:mysql:v1.5.0:go_sql_driver_mysql/vendor/github.com/go-sql-driver/mysql \
> 		go-yaml:yaml:9f266ea9e77c:go_yaml_yaml_1/vendor/gopkg.in/yaml.v3 \
> 		go-yaml:yaml:v2.3.0:go_yaml_yaml/vendor/gopkg.in/yaml.v2 \
>+		gofrs:flock:v0.8.0:gofrs_flock/vendor/github.com/gofrs/flock \
> 		golang:crypto:87dc89f01550:golang_crypto/vendor/golang.org/x/crypto \
> 		golang:net:83d349e8ac1a:golang_net/vendor/golang.org/x/net \
> 		golang:sys:b77594299b42:golang_sys/vendor/golang.org/x/sys \
> 		golang:xerrors:1b5146add898:golang_xerrors/vendor/golang.org/x/xerrors \
> 		google:certificate-transparency-go:v1.0.21:google_certificate_transparency_go/vendor/github.com/google/certificate-transparency-go \
> 		google:uuid:6a5e28554805:google_uuid/vendor/github.com/google/uuid \
>-		ilyam8:flock:v0.7.2:ilyam8_flock/vendor/github.com/ilyam8/flock \
> 		ilyam8:hashstructure:v1.1.0:ilyam8_hashstructure/vendor/github.com/ilyam8/hashstructure \
> 		jessevdk:go-flags:v1.4.0:jessevdk_go_flags/vendor/github.com/jessevdk/go-flags \
> 		layeh:radius:890bc1058917:layeh_radius/vendor/layeh.com/radius \
> 		likexian:gokit:v0.23.3:likexian_gokit/vendor/github.com/likexian/gokit \
> 		likexian:whois-go:v1.7.1:likexian_whois_go/vendor/github.com/likexian/whois-go \
> 		likexian:whois-parser-go:v1.14.5:likexian_whois_parser_go/vendor/github.com/likexian/whois-parser-go \
> 		mattn:go-isatty:v0.0.12:mattn_go_isatty/vendor/github.com/mattn/go-isatty \
> 		miekg:dns:v1.1.29:miekg_dns/vendor/github.com/miekg/dns \
> 		mitchellh:go-homedir:v1.1.0:mitchellh_go_homedir/vendor/github.com/mitchellh/go-homedir \
>-		netdata:go-orchestrator:3b7cd11e4fe1:netdata_go_orchestrator/vendor/github.com/netdata/go-orchestrator \
>+		netdata:go-orchestrator:25eff6ec645e:netdata_go_orchestrator/vendor/github.com/netdata/go-orchestrator \
>+		niemeyer:pretty:a10e7caefd8e:niemeyer_pretty/vendor/github.com/niemeyer/pretty \
> 		pmezard:go-difflib:v1.0.0:pmezard_go_difflib/vendor/github.com/pmezard/go-difflib \
> 		prometheus:common:v0.10.0:prometheus_common/vendor/github.com/prometheus/common \
> 		prometheus:prometheus:v2.5.0:prometheus_prometheus/vendor/github.com/prometheus/prometheus \
> 		smartystreets:goconvey:v1.6.4:smartystreets_goconvey/vendor/github.com/smartystreets/goconvey \
> 		stretchr:testify:v1.6.0:stretchr_testify/vendor/github.com/stretchr/testify \
>+		tomasen:fcgi_client:2bb3d819fd19:tomasen_fcgi_client/vendor/github.com/tomasen/fcgi_client \
> 		vmware:govmomi:v0.22.2:vmware_govmomi/vendor/github.com/vmware/govmomi
>-
> GO_TARGET=	./cmd/godplugin:${PREFIX}/libexec/netdata/plugins.d/god.plugin
> 
> post-patch:
> 	${REINPLACE_CMD} -e 's|/etc/netdata|${PREFIX}/etc/netdata|g' ${WRKSRC}/cmd/godplugin/main.go
> 
> post-install:
> 	${MKDIR} ${STAGEDIR}${PREFIX}/lib/netdata/conf.d
> 	${INSTALL_DATA} ${WRKSRC}/config/go.d.conf ${STAGEDIR}${PREFIX}/lib/netdata/conf.d/go.d.conf.sample
> 	${MKDIR} ${STAGEDIR}${PREFIX}/lib/netdata/conf.d/go.d
> 	cd ${WRKSRC}/config/go.d && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/lib/netdata/conf.d/go.d
> 	(for file in ${STAGEDIR}${PREFIX}/lib/netdata/conf.d/go.d/*.conf; do \
> 		${MV} $$file $$file".sample"; \
> 	done)
> 
> .include <bsd.port.mk>
>Index: net-mgmt/netdata-go/distinfo
>===================================================================
>--- net-mgmt/netdata-go/distinfo	(revision 547648)
>+++ net-mgmt/netdata-go/distinfo	(working copy)
>@@ -1,73 +1,79 @@
>-TIMESTAMP = 1597602912
>-SHA256 (netdata-go.d.plugin-v0.20.0_GH0.tar.gz) = 068e41b4dc8d00edc66f2fe788ae7a6998d2f1e7c2104fee2ba00ceebe7af536
>-SIZE (netdata-go.d.plugin-v0.20.0_GH0.tar.gz) = 577089
>+TIMESTAMP = 1599307659
>+SHA256 (netdata-go.d.plugin-v0.21.0_GH0.tar.gz) = 4a385d65e5a4af865fe170f9f4166e964b919878d209b5b18642f2ec7476db06
>+SIZE (netdata-go.d.plugin-v0.21.0_GH0.tar.gz) = 607179
> SHA256 (DATA-DOG-go-sqlmock-v1.4.1_GH0.tar.gz) = 50a4e370447d4096b288cdbe929fd15fad1196c0e153f068ffdca720196f7f37
> SIZE (DATA-DOG-go-sqlmock-v1.4.1_GH0.tar.gz) = 32714
> SHA256 (Wing924-ltsv-v0.3.1_GH0.tar.gz) = b20c4ed0b836044bd59bbf5ecde4afc1b6eda3879652e8485e42ea5f7db8c087
> SIZE (Wing924-ltsv-v0.3.1_GH0.tar.gz) = 10327
> SHA256 (axiomhq-hyperloglog-a4c4c47bc57f_GH0.tar.gz) = 44eaed28df5f20bbd66e5f0599013ba2a9ab7ff04877e36808fdac729293297a
> SIZE (axiomhq-hyperloglog-a4c4c47bc57f_GH0.tar.gz) = 13867
> SHA256 (cespare-xxhash-v1.1.0_GH0.tar.gz) = 9418be390574092f0ca989b9ae2f5450270ead8125a635a100850b28c8c9c495
> SIZE (cespare-xxhash-v1.1.0_GH0.tar.gz) = 8200
> SHA256 (cloudflare-cfssl-v1.4.1_GH0.tar.gz) = c8a86ef10cbb0c168f3b597db15b31f98b170edb7958f7154edeb29aee41315e
> SIZE (cloudflare-cfssl-v1.4.1_GH0.tar.gz) = 5736648
> SHA256 (davecgh-go-spew-v1.1.1_GH0.tar.gz) = 7d82b9bb7291adbe7498fe946920ab3e7fc9e6cbfc3b2294693fad00bf0dd17e
> SIZE (davecgh-go-spew-v1.1.1_GH0.tar.gz) = 42152
> SHA256 (dgryski-go-metro-280f6062b5bc_GH0.tar.gz) = 0fb7cdcc1a83d1a41e4c3f5722537a56684b340e659639c1e690f89a556ded88
> SIZE (dgryski-go-metro-280f6062b5bc_GH0.tar.gz) = 4393
> SHA256 (fsnotify-fsnotify-v1.4.9_GH0.tar.gz) = 4f888b1cb132026227826751d156c0a2958e7d492e5e38386cde8848ef494dcb
> SIZE (fsnotify-fsnotify-v1.4.9_GH0.tar.gz) = 31900
>+SHA256 (go-check-check-8fa46927fb4f_GH0.tar.gz) = 7e433178d7b915d0df0eb99300cee70d5b23c543414366f03649325b44a1076c
>+SIZE (go-check-check-8fa46927fb4f_GH0.tar.gz) = 31611
> SHA256 (go-ini-ini-v1.57.0_GH0.tar.gz) = e612924cffa395825f32e65db18cff0366705952433e52c6efc81fc1c3adfd2a
> SIZE (go-ini-ini-v1.57.0_GH0.tar.gz) = 48424
> SHA256 (go-sql-driver-mysql-v1.5.0_GH0.tar.gz) = 9d98b46623037447a26a51a203540bf605b6e6220d31f2efc7396242fcb660b5
> SIZE (go-sql-driver-mysql-v1.5.0_GH0.tar.gz) = 90474
> SHA256 (go-yaml-yaml-9f266ea9e77c_GH0.tar.gz) = 63efc9aabcbb56b2c9469927784fd67ecb3a79720c4fa754c511335a04156d04
> SIZE (go-yaml-yaml-9f266ea9e77c_GH0.tar.gz) = 86898
> SHA256 (go-yaml-yaml-v2.3.0_GH0.tar.gz) = 42027002bf258009d498600b04b8c9cbb29d2193185ea7bfa8fefe194fe72a07
> SIZE (go-yaml-yaml-v2.3.0_GH0.tar.gz) = 72816
>+SHA256 (gofrs-flock-v0.8.0_GH0.tar.gz) = 64aa198aee88a6b560e2eb9a87794594e0b57c08a784dcb4bd8a0825b9ec5de6
>+SIZE (gofrs-flock-v0.8.0_GH0.tar.gz) = 8978
> SHA256 (golang-crypto-87dc89f01550_GH0.tar.gz) = d81e26d345c6cd9f132fd69547b14200603d6f3b50622ebceace32dfe456339b
> SIZE (golang-crypto-87dc89f01550_GH0.tar.gz) = 1709204
> SHA256 (golang-net-83d349e8ac1a_GH0.tar.gz) = 5752c376bc6383bf2055281336101c062b881f17ded2e960d718c8256023f9c7
> SIZE (golang-net-83d349e8ac1a_GH0.tar.gz) = 1103298
> SHA256 (golang-sys-b77594299b42_GH0.tar.gz) = 484bf05a828f18a9ea48f32b64322d6cc8e716b5cbfd455be72f445db8495b82
> SIZE (golang-sys-b77594299b42_GH0.tar.gz) = 1534631
> SHA256 (golang-xerrors-1b5146add898_GH0.tar.gz) = 57ba6cacc0a84a2ecbfda1169b5e9c184581dd009136f95d2fca9a5289e49ab1
> SIZE (golang-xerrors-1b5146add898_GH0.tar.gz) = 12200
> SHA256 (google-certificate-transparency-go-v1.0.21_GH0.tar.gz) = 6f9f8b67f19ee6be7b0261342cbd69db13559f40945441a9dfe2db5bf0eae25b
> SIZE (google-certificate-transparency-go-v1.0.21_GH0.tar.gz) = 4401179
> SHA256 (google-uuid-6a5e28554805_GH0.tar.gz) = 6478108a345cc342a323e2c415d6b56b828101a73e3dfc6432122b4c1bfab179
> SIZE (google-uuid-6a5e28554805_GH0.tar.gz) = 12733
>-SHA256 (ilyam8-flock-v0.7.2_GH0.tar.gz) = c9dbf70682fe43c6dcbd2d72fb6d965a0374fb5e9a48ef44cb53b2b0208dbbb8
>-SIZE (ilyam8-flock-v0.7.2_GH0.tar.gz) = 8423
> SHA256 (ilyam8-hashstructure-v1.1.0_GH0.tar.gz) = 6432390e934c5dbdcbcc2c4a857d44d27a745df0045488ff63b91e40e43239ee
> SIZE (ilyam8-hashstructure-v1.1.0_GH0.tar.gz) = 6959
> SHA256 (jessevdk-go-flags-v1.4.0_GH0.tar.gz) = 3be7e8fb4b63887e8aeb55878244c04b7dcbe5ac77211c73ee35e38ca681e611
> SIZE (jessevdk-go-flags-v1.4.0_GH0.tar.gz) = 55452
> SHA256 (layeh-radius-890bc1058917_GH0.tar.gz) = 5d2110802caf3b19bc1cdfc3d6b49db16c63cd3da130557d31c50fd213e13c87
> SIZE (layeh-radius-890bc1058917_GH0.tar.gz) = 76500
> SHA256 (likexian-gokit-v0.23.3_GH0.tar.gz) = 8df8343696d7fad111b079ff47f070bb1cc9df03e893e7ca1a137056253b0d5c
> SIZE (likexian-gokit-v0.23.3_GH0.tar.gz) = 107779
> SHA256 (likexian-whois-go-v1.7.1_GH0.tar.gz) = 4fb9adc1a1dd165329777bc61b664d2c0099398925cc3eee1a83e8b5baae4cce
> SIZE (likexian-whois-go-v1.7.1_GH0.tar.gz) = 7777
> SHA256 (likexian-whois-parser-go-v1.14.5_GH0.tar.gz) = 0c8d48e6e60824a01d631b7cac9c157e6556b8595193580d67ec76874d506a8e
> SIZE (likexian-whois-parser-go-v1.14.5_GH0.tar.gz) = 134235
> SHA256 (mattn-go-isatty-v0.0.12_GH0.tar.gz) = addbdc341d7685ed4cc8d2d8a8fd2bd9b784bde00d0ea99fb251039fc10c611c
> SIZE (mattn-go-isatty-v0.0.12_GH0.tar.gz) = 4548
> SHA256 (miekg-dns-v1.1.29_GH0.tar.gz) = b2a683acf16f7c4559b04db03e186799362255ae0db8c4eceb6b72b0af04274f
> SIZE (miekg-dns-v1.1.29_GH0.tar.gz) = 184242
> SHA256 (mitchellh-go-homedir-v1.1.0_GH0.tar.gz) = 646671c73a84a8dfb4a5a76b80c7b63549ffefa906524d45077301bc7da76600
> SIZE (mitchellh-go-homedir-v1.1.0_GH0.tar.gz) = 3362
>-SHA256 (netdata-go-orchestrator-3b7cd11e4fe1_GH0.tar.gz) = dc6a2927f60c00669d5d075f3f23290bc23644e209cc6b772c11669e1afdb269
>-SIZE (netdata-go-orchestrator-3b7cd11e4fe1_GH0.tar.gz) = 54448
>+SHA256 (netdata-go-orchestrator-25eff6ec645e_GH0.tar.gz) = 6e75320712a856651c9e72886ce5f2166897d46b28ea5261e98d819ba375d90a
>+SIZE (netdata-go-orchestrator-25eff6ec645e_GH0.tar.gz) = 54336
>+SHA256 (niemeyer-pretty-a10e7caefd8e_GH0.tar.gz) = 2a81e75bdd5341bd0fac76a90bb024ed2ac6c8a5d31d70cd715eef75224601e1
>+SIZE (niemeyer-pretty-a10e7caefd8e_GH0.tar.gz) = 9399
> SHA256 (pmezard-go-difflib-v1.0.0_GH0.tar.gz) = 28f3dc1b5c0efd61203ab07233f774740d3bf08da4d8153fb5310db6cea0ebda
> SIZE (pmezard-go-difflib-v1.0.0_GH0.tar.gz) = 11398
> SHA256 (prometheus-common-v0.10.0_GH0.tar.gz) = 349381082ea8e66637c2d2475f1ae0e74ca04a7b91eb3b96817c261b87668fd3
> SIZE (prometheus-common-v0.10.0_GH0.tar.gz) = 107763
> SHA256 (prometheus-prometheus-v2.5.0_GH0.tar.gz) = e1484edbb63480bc5ce75b661a328abb7b7b2c609de41e8fd0af0e6539fe02c7
> SIZE (prometheus-prometheus-v2.5.0_GH0.tar.gz) = 6123272
> SHA256 (smartystreets-goconvey-v1.6.4_GH0.tar.gz) = 88714f84d0a989c4ba60e1f2b65e426dc7e23058ca0b9f06cb77613cb22b010b
> SIZE (smartystreets-goconvey-v1.6.4_GH0.tar.gz) = 1478622
> SHA256 (stretchr-testify-v1.6.0_GH0.tar.gz) = a5c33d77640da2fc2d8db091f9ecdf99214c64f19e7264493bff728706f00bda
> SIZE (stretchr-testify-v1.6.0_GH0.tar.gz) = 84517
>+SHA256 (tomasen-fcgi_client-2bb3d819fd19_GH0.tar.gz) = 8ca824cbc5788ba3ee8e8bbc63f135a6f3d77a1f7173b796f2c6fc8903171641
>+SIZE (tomasen-fcgi_client-2bb3d819fd19_GH0.tar.gz) = 8646
> SHA256 (vmware-govmomi-v0.22.2_GH0.tar.gz) = 738c294440cb7124035c3eab2f0934671dfbafc75c85f0ebfd48fcc584e7d8ac
> SIZE (vmware-govmomi-v0.22.2_GH0.tar.gz) = 1312611
>Index: net-mgmt/netdata-go/pkg-plist
>===================================================================
>--- net-mgmt/netdata-go/pkg-plist	(revision 547648)
>+++ net-mgmt/netdata-go/pkg-plist	(working copy)
>@@ -1,46 +1,47 @@
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/activemq.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/apache.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/bind.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/cockroachdb.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/consul.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/coredns.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/dns_query.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/dnsmasq_dhcp.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/docker_engine.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/dockerhub.conf.sample
>+@sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/elasticsearch.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/example.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/fluentd.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/freeradius.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/hdfs.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/httpcheck.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/k8s_kubelet.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/k8s_kubeproxy.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/lighttpd.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/lighttpd2.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/logstash.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/mysql.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/nginx.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/openvpn.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/phpdaemon.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/phpfpm.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/pihole.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/portcheck.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/prometheus.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/pulsar.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/rabbitmq.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/scaleio.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/solr.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/springboot2.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/squidlog.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/tengine.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/unbound.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/vcsa.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/vernemq.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/vsphere.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/web_log.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/whoisquery.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/wmi.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/x509check.conf.sample
> @sample(netdata,netdata,0640) lib/netdata/conf.d/go.d/zookeeper.conf.sample
> libexec/netdata/plugins.d/god.plugin

Flags:

driesm: maintainer-approval+

Actions: View | Diff

Attachments on bug 249126: 217763 | 217764