FreeBSD Bugzilla – Attachment 229664 Details for
Bug 259992
Mk/Scripts/qa.sh: Bogus 'xx doesn't have a SONAME' messages are printed by stage-qa for some shared libraries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
fix-SONAME.patch
fix-SONAME.patch (text/plain), 1.00 KB, created by
Yuri Victorovich
on 2021-11-23 02:13:01 UTC
(
hide
)
Description:
fix-SONAME.patch
Filename:
MIME Type:
Creator:
Yuri Victorovich
Created:
2021-11-23 02:13:01 UTC
Size:
1.00 KB
patch
obsolete
>diff --git a/Mk/Scripts/qa.sh b/Mk/Scripts/qa.sh >index 9caf01581b47..d494351258fb 100644 >--- a/Mk/Scripts/qa.sh >+++ b/Mk/Scripts/qa.sh >@@ -666,7 +666,7 @@ proxydeps() { > # When grep -q finds a match it will close the pipe immediately. > # This may cause the test to fail when pipefail is turned on. > set +o pipefail >- if ! readelf -d "${dep_file}" | grep -q SONAME; then >+ if ! readelf -d "${dep_file}" | grep SONAME > /dev/null; then > err "${file} is linked to ${dep_file} which does not have a SONAME. ${dep_file_pkg} needs to be fixed." > fi > set -o pipefail >@@ -717,7 +717,7 @@ sonames() { > [ -z "${f}" ] && continue > # Ignore symlinks > [ -f "${f}" -a ! -L "${f}" ] || continue >- if ! readelf -d ${f} | grep -q SONAME; then >+ if ! readelf -d ${f} | grep SONAME > /dev/null; then > warn "${f} doesn't have a SONAME." > warn "pkg(8) will not register it as being provided by the port." > warn "If another port depend on it, pkg will not be able to know where it comes from."
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 259992
: 229664