Attachment 235706 Details for Bug 265661 – upstream fix of a regression in sbcl 2.2.7

upstream fix of a regression in sbcl 2.2.7

patch-value-cell-value.diff (text/plain), 1.21 KB, created by jinxiaoyong on 2022-08-05 18:08:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: jinxiaoyong

Created: 2022-08-05 18:08:28 UTC

Size: 1.21 KB

patch

obsolete

>from: https://sourceforge.net/p/sbcl/sbcl/ci/48d686f9
>
>Accept that value-cell-value can move to R/O space
>Fixes lp#1983218
>--- src/runtime/stringspace.c
>+++ src/runtime/stringspace.c
>@@ -76,6 +76,7 @@
>                widetag == RATIO_WIDETAG || widetag == COMPLEX_WIDETAG ||
>                widetag == SIMPLE_ARRAY_WIDETAG ||
>                (widetag >= COMPLEX_BASE_STRING_WIDETAG && widetag <= COMPLEX_ARRAY_WIDETAG) ||
>+               widetag == VALUE_CELL_WIDETAG ||
>                widetag == WEAK_POINTER_WIDETAG) {
>         int len = object_size(object), i;
>         for (i=1; i<len; ++i) FIX(object[i]);
>--- tests/save1.test.sh
>+++ tests/save1.test.sh
>@@ -23,6 +23,11 @@
>   ;; but maybe someone changed it :immobile, so bind it to be certain.
>   (let (#+immobile-code (sb-c::*compile-to-memory-space* :dynamic))
>      (defvar *afun* (compile nil '(lambda (x) (- (length x))))))
>+  ;; test for lp#1983218 - a VALUE-CELL holding a readonly string could crash
>+  (defun mkcell (x) (sb-sys:%primitive sb-vm::make-value-cell x nil))
>+  (compile 'mkcell)
>+  (defvar *cell* (mkcell (symbol-name '*print-base*)))
>+  ;;
>   (save-lisp-and-die "$tmpcore")
> EOF
> run_sbcl_with_core "$tmpcore" --noinform --no-userinit --no-sysinit --noprint \

Actions: View

Attachments on bug 265661: 235706 | 235710