Attachment 237110 Details for Bug 266853 – Patch for devel-unittest

[patch] Patch for devel-unittest

0001-devel-unittest-cpp-Deprecate-and-set-expiration-date.patch (text/plain), 2.14 KB, created by Daniel Engberg on 2022-10-05 16:37:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Engberg

Created: 2022-10-05 16:37:27 UTC

Size: 2.14 KB

patch

obsolete

>From c0ee94b4f174eacf647fe53e26d32f9c5b142733 Mon Sep 17 00:00:00 2001
>From: Daniel Engberg <diizzy@FreeBSD.org>
>Date: Wed, 5 Oct 2022 14:07:49 +0200
>Subject: [PATCH] devel/unittest-cpp: Deprecate and set expiration date to
> 2022-12-31
>
>Upstream has listed project on hiatus for more than 2 years
>Disable broken test when NDEBUG is defined
>
>Reference: https://github.com/unittest-cpp/unittest-cpp/issues/180
>
>PR:		266721
>---
> devel/unittest-cpp/Makefile                   |  3 ++
> .../files/patch-tests_TestTest.cpp            | 32 +++++++++++++++++++
> 2 files changed, 35 insertions(+)
> create mode 100644 devel/unittest-cpp/files/patch-tests_TestTest.cpp
>
>diff --git a/devel/unittest-cpp/Makefile b/devel/unittest-cpp/Makefile
>index 0a0d679fe162..c5c06247e4e0 100644
>--- a/devel/unittest-cpp/Makefile
>+++ b/devel/unittest-cpp/Makefile
>@@ -10,6 +10,9 @@ WWW=		https://github.com/unittest-cpp/unittest-cpp
> LICENSE=	MIT
> LICENSE_FILE=	${WRKSRC}/LICENSE
> 
>+DEPRECATED=	Upstream have declared hiatus status since 2+ years back. Please consider using devel/googletest instead
>+EXPIRATION_DATE=2022-12-31
>+
> USE_GITHUB=	yes
> 
> USES=		cmake
>diff --git a/devel/unittest-cpp/files/patch-tests_TestTest.cpp b/devel/unittest-cpp/files/patch-tests_TestTest.cpp
>new file mode 100644
>index 000000000000..ed09c84e203e
>--- /dev/null
>+++ b/devel/unittest-cpp/files/patch-tests_TestTest.cpp
>@@ -0,0 +1,32 @@
>+--- tests/TestTest.cpp.orig	2022-10-05 11:53:09 UTC
>++++ tests/TestTest.cpp
>+@@ -74,29 +74,6 @@ namespace {
>+ 
>+ #if !defined(UNITTEST_MINGW) && !defined(UNITTEST_WIN32)
>+ // Skip this test in debug because some debuggers don't like it.
>+-#if defined(NDEBUG)
>+-   TEST(CrashingTestsAreReportedAsFailures)
>+-   {
>+-      class CrashingTest : public Test
>+-      {
>+-      public:
>+-         CrashingTest() : Test("crashing") {}
>+-         virtual void RunImpl() const
>+-         {
>+-
>+-            reinterpret_cast< void (*)() >(0)();
>+-         }
>+-      };
>+-
>+-      TestResults results;
>+-      {
>+-         ScopedCurrentTest scopedResult(results);
>+-         CrashingTest().Run();
>+-      }
>+-
>+-      CHECK_EQUAL(1, results.GetFailureCount());
>+-   }
>+-#endif
>+ #endif
>+ #endif
>+ 
>-- 
>2.37.3
>

Actions: View | Diff

Attachments on bug 266853: 237110