Attachment 238141 Details for Bug 267827 – Revert part of security patch

[patch] Revert part of security patch

0001-heimdal-Fix-Too-large-time-skew-client-time-1970-01-.patch (text/plain), 1.35 KB, created by Cy Schubert on 2022-11-17 16:03:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Cy Schubert

Created: 2022-11-17 16:03:50 UTC

Size: 1.35 KB

patch

obsolete

>From 0037896a1c7764a8559711ec411d1c541f681f6f Mon Sep 17 00:00:00 2001
>From: Cy Schubert <cy@FreeBSD.org>
>Date: Thu, 17 Nov 2022 07:43:29 -0800
>Subject: [PATCH] heimdal: Fix: Too large time skew, client time
> 1970-01-01T01:00:00
>
>Part of ed549cb0c53f zeroed out a data structure in the resulting code-file
>when a TUTCTime type was freed. This code is not in the upstream heimdal,
>though it may have been removed at some point.
>
>PR:		267827
>Reported by:	Peter Much <pmc@citylink.dinoex.sub.org>
>Tested by:
>Fixes:		ed549cb0c53f
>MFC after:	3 days
>---
> crypto/heimdal/lib/asn1/gen_free.c | 7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/crypto/heimdal/lib/asn1/gen_free.c b/crypto/heimdal/lib/asn1/gen_free.c
>index 74449fe6ca82..b9cae7533b17 100644
>--- a/crypto/heimdal/lib/asn1/gen_free.c
>+++ b/crypto/heimdal/lib/asn1/gen_free.c
>@@ -61,13 +61,6 @@ free_type (const char *name, const Type *t, int preserve)
>     case TNull:
>     case TGeneralizedTime:
>     case TUTCTime:
>-        /*
>-         * This doesn't do much, but it leaves zeros where garbage might
>-         * otherwise have been found.  Gets us closer to having the equivalent
>-         * of a memset()-to-zero data structure after calling the free
>-         * functions.
>-         */
>-        fprintf(codefile, "*%s = 0;\n", name);
> 	break;
>     case TBitString:
> 	if (ASN1_TAILQ_EMPTY(t->members))
>-- 
>2.38.1
>

Actions: View | Diff

Attachments on bug 267827: 238141