Attachment 238843 Details for Bug 268413 – security/s2n-tls: fix build with clang 15

[patch] security/s2n-tls: fix build with clang 15

security__s2n-tls-fix-clang15-build-1.diff (text/plain), 2.59 KB, created by Dimitry Andric on 2022-12-16 16:52:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2022-12-16 16:52:17 UTC

Size: 2.59 KB

patch

obsolete

>commit 89ab65b10ee622b588192d970799b446d25cef98
>Author: Dimitry Andric <dim@FreeBSD.org>
>Date:   Fri Dec 16 17:47:40 2022 +0100
>
>    security/s2n-tls: fix build with clang 15
>    
>    During an exp-run for llvm 15 (see bug 265425), it turned out that
>    security/s2n-tls failed to build with clang 15:
>    
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/crypto/s2n_aead_cipher_aes_gcm.c:21:
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/tls/s2n_crypto.h:18:
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/tls/s2n_config.h:19:
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/crypto/s2n_certificate.h:23:
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/crypto/s2n_pkey.h:20:
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/crypto/s2n_signature.h:17:
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/tls/s2n_tls_parameters.h:18:
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/crypto/s2n_hash.h:24:
>      In file included from /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/crypto/s2n_evp.h:21:
>      /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/crypto/s2n_openssl.h:59:28: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>      bool s2n_libcrypto_is_awslc();
>                                 ^
>                                  void
>      /wrkdirs/usr/ports/security/s2n-tls/work/s2n-tls-1.3.29/crypto/s2n_openssl.h:60:32: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>      bool s2n_libcrypto_is_boringssl();
>                                     ^
>                                      void
>    
>    And many similar errors. This is due to the port using -Werror by
>    default, and prototypes are now more strictly checked. Add
>    -Wno-strict-prototypes to CFLAGS to suppress the warnings-as-errors.
>
>diff --git a/security/s2n-tls/Makefile b/security/s2n-tls/Makefile
>index 9ab910199a01..042c3bb20be2 100644
>--- a/security/s2n-tls/Makefile
>+++ b/security/s2n-tls/Makefile
>@@ -31,6 +31,8 @@ ASM_DESC=	Enable PQ crypto assembly (reqs AVX2 and BMI2 support)
> ASM_CMAKE_OFF=	-DS2N_NO_PQ_ASM=1
> LTO_CMAKE_BOOL=	S2N_LTO
> 
>+CFLAGS+=	-Wno-strict-prototypes
>+
> .include <bsd.port.options.mk>
> 
> .if ${ARCH} != aarch64 && ${ARCH} != amd64 && ${ARCH} != arm && ${ARCH} != armv6 && ${ARCH} != armv7 && ${ARCH} != i386

Actions: View | Diff

Attachments on bug 268413: 238843