Attachment 242010 Details for Bug 270189 – poudriere friendly patch that uses clang14 (improved but still WIP)

[patch] poudriere friendly patch that uses clang14 (improved but still WIP)

virtualbox_6.1.44_2.patch (text/plain), 7.99 KB, created by pr on 2023-05-06 08:59:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: pr

Created: 2023-05-06 08:59:30 UTC

Size: 7.99 KB

patch

obsolete

>diff --git a/emulators/virtualbox-ose-additions/Makefile b/emulators/virtualbox-ose-additions/Makefile
>index 3a6dc9421570..434f65c9f2fa 100644
>--- a/emulators/virtualbox-ose-additions/Makefile
>+++ b/emulators/virtualbox-ose-additions/Makefile
>@@ -1,6 +1,5 @@
> PORTNAME=	virtualbox-ose
>-PORTVERSION=	6.1.36
>-PORTREVISION?=	2
>+PORTVERSION=	6.1.44
> CATEGORIES=	emulators
> MASTER_SITES=	https://download.virtualbox.org/virtualbox/${PORTVERSION}/
> PKGNAMESUFFIX?=	-additions
>diff --git a/emulators/virtualbox-ose-additions/distinfo b/emulators/virtualbox-ose-additions/distinfo
>index c264e433839f..8413c585033b 100644
>--- a/emulators/virtualbox-ose-additions/distinfo
>+++ b/emulators/virtualbox-ose-additions/distinfo
>@@ -1,3 +1,3 @@
>-TIMESTAMP = 1658298869
>-SHA256 (VirtualBox-6.1.36.tar.bz2) = e47942e42892c13c621869865e2b7b320340154f0fa74ecbdaf18fdaf70ef047
>-SIZE (VirtualBox-6.1.36.tar.bz2) = 165685382
>+TIMESTAMP = 1682671010
>+SHA256 (VirtualBox-6.1.44.tar.bz2) = 34a0235d878165453f6a15e34d74ed19b8878afacbb34e6f3682556f3487a48c
>+SIZE (VirtualBox-6.1.44.tar.bz2) = 165775421
>diff --git a/emulators/virtualbox-ose-kmod/Makefile b/emulators/virtualbox-ose-kmod/Makefile
>index efd78069f3c8..c2692e3ea865 100644
>--- a/emulators/virtualbox-ose-kmod/Makefile
>+++ b/emulators/virtualbox-ose-kmod/Makefile
>@@ -1,5 +1,5 @@
> PORTNAME=	virtualbox-ose
>-PORTVERSION=	6.1.36
>+PORTVERSION=	6.1.44
> PORTREVISION=	1
> CATEGORIES=	emulators
> MASTER_SITES=	https://download.virtualbox.org/virtualbox/${PORTVERSION}/
>diff --git a/emulators/virtualbox-ose-kmod/distinfo b/emulators/virtualbox-ose-kmod/distinfo
>index c264e433839f..9896172468b4 100644
>--- a/emulators/virtualbox-ose-kmod/distinfo
>+++ b/emulators/virtualbox-ose-kmod/distinfo
>@@ -1,3 +1,3 @@
>-TIMESTAMP = 1658298869
>-SHA256 (VirtualBox-6.1.36.tar.bz2) = e47942e42892c13c621869865e2b7b320340154f0fa74ecbdaf18fdaf70ef047
>-SIZE (VirtualBox-6.1.36.tar.bz2) = 165685382
>+TIMESTAMP = 1682670994
>+SHA256 (VirtualBox-6.1.44.tar.bz2) = 34a0235d878165453f6a15e34d74ed19b8878afacbb34e6f3682556f3487a48c
>+SIZE (VirtualBox-6.1.44.tar.bz2) = 165775421
>diff --git a/emulators/virtualbox-ose/Makefile b/emulators/virtualbox-ose/Makefile
>index 301f9a4b855e..0b4176d059ca 100644
>--- a/emulators/virtualbox-ose/Makefile
>+++ b/emulators/virtualbox-ose/Makefile
>@@ -1,5 +1,5 @@
> PORTNAME=	virtualbox-ose
>-PORTVERSION=	6.1.36
>+PORTVERSION=	6.1.44
> PORTREVISION=	2
> CATEGORIES=	emulators
> MASTER_SITES=	https://download.virtualbox.org/virtualbox/${PORTVERSION}/
>@@ -32,7 +32,6 @@ USE_GNOME=	libidl libxml2
> 
> HAS_CONFIGURE=	yes
> CONFIGURE_ARGS=	--disable-java --passive-mesa
>-CONFIGURE_ARGS+=	--with-gcc="${CC}" --with-g++="${CXX}"
> 
> CONFLICTS_INSTALL=	virtualbox-ose-additions-* \
> 			virtualbox-ose-devel \
>@@ -115,6 +114,11 @@ USE_RC_SUBR=	vboxheadless vboxwatchdog
> 
> .include <bsd.port.options.mk>
> 
>+# llvm10 in FreeBSD before r364284 miscompiles virtualbox 6.1 causing errors.
>+# llvm15 builds but the executable throws error "VERR_INTERNAL_ERROR_3"
>+# force llvm from ports to be between 11 and 14
>+USES+=		llvm:min=11,max=14
>+
> .if ${SLAVE_PORT} == no
> CONFLICTS_INSTALL+=	virtualbox-ose-nox11
> OPTIONS_DEFAULT+=	PYTHON
>@@ -211,19 +215,6 @@ KMK_FLAGS+=	-j${MAKE_JOBS_NUMBER}
> 
> .include <bsd.port.pre.mk>
> 
>-.if ${CHOSEN_COMPILER_TYPE} == clang
>-# llvm10 in FreeBSD before r364284 miscompiles virtualbox 6.1 causing errors.
>-# force llvm11 from ports
>-.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1300109
>-BUILD_DEPENDS+=	clang${VBOX_LLVM_VER}:devel/llvm${VBOX_LLVM_VER}
>-CC=		clang${VBOX_LLVM_VER}
>-CXX=		clang++${VBOX_LLVM_VER}
>-VBOX_LLVM_VER?=	11
>-.endif
>-PATCH_DEPENDS+=	${LOCALBASE}/share/kBuild/tools/GXX3.kmk:devel/kBuild
>-EXTRA_PATCHES+=	${PATCHDIR}/extrapatch-src-VBox-Devices-PC-ipxe-Makefile.kmk
>-.endif
>-
> .if ${PYTHON_MAJOR_VER} >= 3
> PLIST_SUB+=	PYTHON_PYCDIR=/__pycache__/ \
> 		PYTHON_PYCEXT=.cpython-${PYTHON_SUFFIX}.pyc
>@@ -309,6 +300,13 @@ post-patch:
> 	@${SED} -e 's|GXX3|VBoxGccFreeBSD|g' \
> 	    ${LOCALBASE}/share/kBuild/tools/GXX3.kmk > \
> 	    ${WRKSRC}/tools/kBuildTools/VBoxGccFreeBSD.kmk
>+CONFIGURE_ARGS+=	--with-gcc="clang${LLVM_VERSION}" --with-g++="clang++${LLVM_VERSION}"
>+PATCH_DEPENDS+=	${LOCALBASE}/share/kBuild/tools/GXX3.kmk:devel/kBuild
>+EXTRA_PATCHES+=	${PATCHDIR}/extrapatch-src-VBox-Devices-PC-ipxe-Makefile.kmk
>+EXTRA_PATCHES+=	${PATCHDIR}/extrapatch-src_VBox_Devices_PC_ipxe_src_core_settings.c
>+EXTRA_PATCHES+=	${PATCHDIR}/extrapatch-src_VBox_Devices_PC_ipxe_src_net_tcp_httpcore.c
>+.else
>+CONFIGURE_ARGS+=	--with-gcc="${CC}" --with-g++="${CXX}"
> .endif
> 	# Causes a "reinplace" QA warning with default LOCALBASE
> 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
>diff --git a/emulators/virtualbox-ose/distinfo b/emulators/virtualbox-ose/distinfo
>index 1f32b6fd8315..941e8fe5bb20 100644
>--- a/emulators/virtualbox-ose/distinfo
>+++ b/emulators/virtualbox-ose/distinfo
>@@ -1,5 +1,5 @@
>-TIMESTAMP = 1658298869
>-SHA256 (VirtualBox-6.1.36.tar.bz2) = e47942e42892c13c621869865e2b7b320340154f0fa74ecbdaf18fdaf70ef047
>-SIZE (VirtualBox-6.1.36.tar.bz2) = 165685382
>-SHA256 (VBoxGuestAdditions_6.1.36.iso) = c987cdc8c08c579f56d921c85269aeeac3faf636babd01d9461ce579c9362cdd
>-SIZE (VBoxGuestAdditions_6.1.36.iso) = 63803392
>+TIMESTAMP = 1682670965
>+SHA256 (VirtualBox-6.1.44.tar.bz2) = 34a0235d878165453f6a15e34d74ed19b8878afacbb34e6f3682556f3487a48c
>+SIZE (VirtualBox-6.1.44.tar.bz2) = 165775421
>+SHA256 (VBoxGuestAdditions_6.1.44.iso) = a88d947b0055ae0f08962fa1b5788247272903b6bca3f1a9ad0cb6bc8706ecf8
>+SIZE (VBoxGuestAdditions_6.1.44.iso) = 63952896
>diff --git a/emulators/virtualbox-ose/files/extrapatch-src_VBox_Devices_PC_ipxe_src_core_settings.c b/emulators/virtualbox-ose/files/extrapatch-src_VBox_Devices_PC_ipxe_src_core_settings.c
>new file mode 100644
>index 000000000000..603c0184a96f
>--- /dev/null
>+++ b/emulators/virtualbox-ose/files/extrapatch-src_VBox_Devices_PC_ipxe_src_core_settings.c
>@@ -0,0 +1,11 @@
>+--- src/VBox/Devices/PC/ipxe/src/core/settings.c.orig	2023-04-13 11:24:00.000000000 +0200
>++++ src/VBox/Devices/PC/ipxe/src/core/settings.c	2023-04-28 11:09:40.133502000 +0200
>+@@ -286,7 +286,7 @@
>+ 						     const char *name ) {
>+ 	struct {
>+ 		struct autovivified_settings autovivified;
>+-		char name[ strlen ( name ) + 1 /* NUL */ ];
>++		char name[ 32 ];
>+ 	} *new_child;
>+ 	struct settings *settings;
>+ 
>diff --git a/emulators/virtualbox-ose/files/extrapatch-src_VBox_Devices_PC_ipxe_src_net_tcp_httpcore.c b/emulators/virtualbox-ose/files/extrapatch-src_VBox_Devices_PC_ipxe_src_net_tcp_httpcore.c
>new file mode 100644
>index 000000000000..b314407b9cda
>--- /dev/null
>+++ b/emulators/virtualbox-ose/files/extrapatch-src_VBox_Devices_PC_ipxe_src_net_tcp_httpcore.c
>@@ -0,0 +1,15 @@
>+--- src/VBox/Devices/PC/ipxe/src/net/tcp/httpcore.c.orig	2023-04-13 11:24:16.000000000 +0200
>++++ src/VBox/Devices/PC/ipxe/src/net/tcp/httpcore.c	2023-04-28 20:13:10.781920000 +0200
>+@@ -646,9 +646,9 @@
>+ 	int request_len = unparse_uri ( NULL, 0, http->uri,
>+ 					URI_PATH_BIT | URI_QUERY_BIT );
>+ 	struct {
>+-		uint8_t user_pw[ user_pw_len + 1 /* NUL */ ];
>+-		char user_pw_base64[ user_pw_base64_len + 1 /* NUL */ ];
>+-		char request[ request_len + 1 /* NUL */ ];
>++		uint8_t user_pw[ 32 ];
>++		char user_pw_base64[ 64 ];
>++		char request[ 1024 ];
>+ 		char range[48]; /* Enough for two 64-bit integers in decimal */
>+ 	} *dynamic;
>+ 	int partial;
>diff --git a/emulators/virtualbox-ose/pkg-plist b/emulators/virtualbox-ose/pkg-plist
>index f61048647e6c..b3058f23ff9e 100644
>--- a/emulators/virtualbox-ose/pkg-plist
>+++ b/emulators/virtualbox-ose/pkg-plist
>@@ -552,6 +552,7 @@ lib/virtualbox/components/VirtualBox_XPCOM.xpt
> %%NLS%%%%DATADIR%%/nls/VirtualBox_id.qm
> %%NLS%%%%DATADIR%%/nls/VirtualBox_it.qm
> %%NLS%%%%DATADIR%%/nls/VirtualBox_ja.qm
>+%%NLS%%%%DATADIR%%/nls/VirtualBox_ka.qm
> %%NLS%%%%DATADIR%%/nls/VirtualBox_km_KH.qm
> %%NLS%%%%DATADIR%%/nls/VirtualBox_ko.qm
> %%NLS%%%%DATADIR%%/nls/VirtualBox_lt.qm
>@@ -590,6 +591,7 @@ lib/virtualbox/components/VirtualBox_XPCOM.xpt
> %%NLS%%%%DATADIR%%/nls/qt_id.qm
> %%NLS%%%%DATADIR%%/nls/qt_it.qm
> %%NLS%%%%DATADIR%%/nls/qt_ja.qm
>+%%NLS%%%%DATADIR%%/nls/qt_ka.qm
> %%NLS%%%%DATADIR%%/nls/qt_km_KH.qm
> %%NLS%%%%DATADIR%%/nls/qt_ko.qm
> %%NLS%%%%DATADIR%%/nls/qt_lt.qm

Actions: View | Diff

Attachments on bug 270189: 240856 | 241099 | 241524 | 241915 | 241924 | 242010 | 242011 | 242215 | 242284 | 242510