Attachment 242133 Details for Bug 254596 – second patch, same content, but in "git format-patch" format

second patch, same content, but in "git format-patch" format

file_254596.txt (text/plain), 1.81 KB, created by paul vixie on 2023-05-12 16:50:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: paul vixie

Created: 2023-05-12 16:50:23 UTC

Size: 1.81 KB

patch

obsolete

>From 755ad42e8923c98558ca1dd32886e261c6508754 Mon Sep 17 00:00:00 2001
>From: Paul Vixie <paul@redbarn.org>
>Date: Fri, 12 May 2023 16:37:20 +0000
>Subject: [PATCH] provisional fix
>
>---
> if_vlan.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
>diff --git a/if_vlan.c b/if_vlan.c
>index 21082f2..516ea7e 100644
>--- a/if_vlan.c
>+++ b/if_vlan.c
>@@ -1843,14 +1843,22 @@ vlan_capabilities(struct ifvlan *ifv)
>        }
>
>        /*
>-        * If the parent interface can do LRO and checksum offloading on
>-        * VLANs, then guess it may do LRO on VLANs.  False positive here
>-        * cost nothing, while false negative may lead to some confusions.
>+        * If the parent interface is not a bridge and can do LRO and
>+        * checksum offloading on VLANs, then guess it may do LRO on VLANs.
>+        * False positive here cost nothing, while false negative may lead
>+        * to some confusions. According to Wikipedia:
>+        *
>+        * "LRO should not operate on machines acting as routers, as it breaks
>+        * the end-to-end principle and can significantly impact performance."
>+        *
>+        * The same reasoning applies to machines acting as bridges.
>         */
>-       if (p->if_capabilities & IFCAP_VLAN_HWCSUM)
>-               cap |= p->if_capabilities & IFCAP_LRO;
>-       if (p->if_capenable & IFCAP_VLAN_HWCSUM)
>-               ena |= p->if_capenable & IFCAP_LRO;
>+       if (ifp->if_bridge == NULL) {
>+               if (p->if_capabilities & IFCAP_VLAN_HWCSUM)
>+                       cap |= p->if_capabilities & IFCAP_LRO;
>+               if (p->if_capenable & IFCAP_VLAN_HWCSUM)
>+                       ena |= p->if_capenable & IFCAP_LRO;
>+       }
>
>        /*
>         * If the parent interface can offload TCP connections over VLANs then
>--
>2.40.1

Actions: View

Attachments on bug 254596: 242067 | 242133 | 242136