Attachment 242169 Details for Bug 271415 – net/norm: fix build with clang 16

[patch] net/norm: fix build with clang 16

net__norm-fix-clang16-build-1.diff (text/plain), 1.57 KB, created by Dimitry Andric on 2023-05-14 15:11:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2023-05-14 15:11:12 UTC

Size: 1.57 KB

patch

obsolete

>commit aac89f3fe3e2a4ea80e29234dcb99130b722e7fb
>Author: Dimitry Andric <dim@FreeBSD.org>
>Date:   2023-05-14 17:06:42 +0200
>
>    net/norm: fix build with clang 16
>    
>    Since clang 16 (and gcc 11) the default C++ standard is now gnu++17.
>    Because net/norm's build system does not explicitly set the C++
>    standard, this leads to several errors:
>    
>      ../src/common/normEncoderRS8.cpp:264:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
>          USE_GF_MULC ;
>          ^
>      ../src/common/normEncoderRS8.cpp:136:21: note: expanded from macro 'USE_GF_MULC'
>      #define USE_GF_MULC register gf * __gf_mulc_
>                          ^
>      ../src/common/normEncoderRS8.cpp:265:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
>          register gf* dst = dst1;
>          ^~~~~~~~~
>      ../src/common/normEncoderRS8.cpp:266:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
>          register gf* src = src1 ;
>          ^~~~~~~~~
>    
>    Add USE_CXXSTD=gnu++98 to compile for C++98 with GNU extensions instead,
>    as net/norm does not seem to use any C++11 or later constructs.
>
>diff --git a/net/norm/Makefile b/net/norm/Makefile
>index 4c0cc829fd0a..4f16626f4561 100644
>--- a/net/norm/Makefile
>+++ b/net/norm/Makefile
>@@ -20,6 +20,7 @@ WWW=		https://www.nrl.navy.mil/itd/ncs/products/norm
> WRKSRC=		${WRKDIR}/norm-${DISTVERSION}
> 
> USES=		libtool tar:tgz waf
>+USE_CXXSTD=	gnu++98
> USE_LDCONFIG=	yes
> PLIST_FILES=	include/normApi.h lib/libnorm.so lib/libnorm.so.1 \
> 		lib/libnorm.so.1.0.0

Actions: View | Diff

Attachments on bug 271415: 242169