Attachment 242176 Details for Bug 271425 – x11-toolkits/open-motif: fix build with clang 16

[patch] x11-toolkits/open-motif: fix build with clang 16

x11-toolkits__open-motif-fix-clang16-build-1.diff (text/plain), 1.72 KB, created by Dimitry Andric on 2023-05-14 19:36:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2023-05-14 19:36:35 UTC

Size: 1.72 KB

patch

obsolete

>commit 3214125dc4440ad1e6062df03254d40fbea55aee
>Author: Dimitry Andric <dim@FreeBSD.org>
>Date:   2023-05-14 21:31:43 +0200
>
>    x11-toolkits/open-motif: fix build with clang 16
>    
>    Clang 16 has a new error about incompatible function types, which shows
>    up when building x11-toolkits/open-motif:
>    
>      WmError.c:134:24: error: incompatible function pointer types passing 'void (char *)' to parameter of type 'void (*)(String) __attribute__((noreturn))' (aka 'void (*)(char *) __attribute__((noreturn))') [-Wincompatible-function-pointer-types]
>          XtSetErrorHandler (WmXtErrorHandler);
>                             ^~~~~~~~~~~~~~~~
>      /usr/local/include/X11/Intrinsic.h:1776:1: note: passing argument to parameter here
>      );
>      ^
>    
>    In this case the declaration of the callback function for
>    XtSetErrorHandler() shoud have a noreturn attribute, specifically using
>    the _X_NORETURN macro.
>
>diff --git a/x11-toolkits/open-motif/files/patch-clients_mwm_WmError.h b/x11-toolkits/open-motif/files/patch-clients_mwm_WmError.h
>new file mode 100644
>index 000000000000..c25975f099a8
>--- /dev/null
>+++ b/x11-toolkits/open-motif/files/patch-clients_mwm_WmError.h
>@@ -0,0 +1,11 @@
>+--- clients/mwm/WmError.h.orig	2017-08-17 00:38:43 UTC
>++++ clients/mwm/WmError.h
>+@@ -32,7 +32,7 @@ extern int WmXIOErrorHandler (Display *display);
>+ extern void WmInitErrorHandler (Display *display);
>+ extern int WmXErrorHandler (Display *display, XErrorEvent *errorEvent);
>+ extern int WmXIOErrorHandler (Display *display);
>+-extern void WmXtErrorHandler (char *message);
>++extern void WmXtErrorHandler (char *message) _X_NORETURN;
>+ extern void WmXtWarningHandler (char *message);
>+ extern void Warning (char *message);
>+ #ifndef NO_MESSAGE_CATALOG

Actions: View | Diff

Attachments on bug 271425: 242176