Attachment 242301 Details for Bug 271540 – net/rubygem-grpc: fix build with clang 16

[patch] net/rubygem-grpc: fix build with clang 16

net__rubygem-grpc-fix-clang16-build-1.diff (text/plain), 2.38 KB, created by Dimitry Andric on 2023-05-20 20:19:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2023-05-20 20:19:23 UTC

Size: 2.38 KB

patch

obsolete

>commit b1276988438cb7ee0aa57fabe111d4a4f0ac6f35
>Author: Dimitry Andric <dim@FreeBSD.org>
>Date:   2023-05-20 22:06:45 +0200
>
>    net/rubygem-grpc: fix build with clang 16
>    
>    Clang 16 has a new error about incompatible function types, which shows
>    up when building net/rubygem-grpc:
>    
>      rb_channel.c:764:40: error: incompatible function pointer types passing 'VALUE (VALUE)' (aka 'unsigned long (unsigned long)') to parameter of type 'VALUE (*)(void *)' (aka 'unsigned long (*)(void *)') [-Wincompatible-function-pointer-types]
>        background_thread = rb_thread_create(run_poll_channels_loop, NULL);
>                                             ^~~~~~~~~~~~~~~~~~~~~~
>      /usr/local/include/ruby-3.1/ruby/internal/intern/thread.h:190:32: note: passing argument to parameter 'f' here
>      VALUE rb_thread_create(VALUE (*f)(void *g), void *g);
>                                     ^
>    
>    Fix it by adjusting the parameters for the thread callback functions.
>
>diff --git a/net/rubygem-grpc/files/patch-src_ruby_ext_grpc_rb__channel.c b/net/rubygem-grpc/files/patch-src_ruby_ext_grpc_rb__channel.c
>new file mode 100644
>index 000000000000..8e77d1b89f9c
>--- /dev/null
>+++ b/net/rubygem-grpc/files/patch-src_ruby_ext_grpc_rb__channel.c
>@@ -0,0 +1,11 @@
>+--- src/ruby/ext/grpc/rb_channel.c.orig	2023-05-20 19:48:13 UTC
>++++ src/ruby/ext/grpc/rb_channel.c
>+@@ -694,7 +694,7 @@ static void run_poll_channels_loop_unblocking_func(voi
>+ }
>+ 
>+ // Poll channel connectivity states in background thread without the GIL.
>+-static VALUE run_poll_channels_loop(VALUE arg) {
>++static VALUE run_poll_channels_loop(void *arg) {
>+   (void)arg;
>+   gpr_log(
>+       GPR_DEBUG,
>diff --git a/net/rubygem-grpc/files/patch-src_ruby_ext_grpc_rb__event__thread.c b/net/rubygem-grpc/files/patch-src_ruby_ext_grpc_rb__event__thread.c
>new file mode 100644
>index 000000000000..db904b46664e
>--- /dev/null
>+++ b/net/rubygem-grpc/files/patch-src_ruby_ext_grpc_rb__event__thread.c
>@@ -0,0 +1,11 @@
>+--- src/ruby/ext/grpc/rb_event_thread.c.orig	2023-05-20 19:51:52 UTC
>++++ src/ruby/ext/grpc/rb_event_thread.c
>+@@ -114,7 +114,7 @@ static void grpc_rb_event_unblocking_func(void* arg) {
>+ 
>+ /* This is the implementation of the thread that handles auth metadata plugin
>+  * events */
>+-static VALUE grpc_rb_event_thread(VALUE arg) {
>++static VALUE grpc_rb_event_thread(void *arg) {
>+   grpc_rb_event* event;
>+   (void)arg;
>+   grpc_ruby_init();

Actions: View | Diff

Attachments on bug 271540: 242301