FreeBSD Bugzilla – Attachment 244386 Details for
Bug 273289
smartpqi: fix panic on removal of SAS drive
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
move free out of spinlock (new driver)
smartpqi.diff (text/plain), 839 bytes, created by
John F. Carr
on 2023-08-27 13:47:57 UTC
(
hide
)
Description:
move free out of spinlock (new driver)
Filename:
MIME Type:
Creator:
John F. Carr
Created:
2023-08-27 13:47:57 UTC
Size:
839 bytes
patch
obsolete
>commit bdf4ee8e0d589cd2ceba6ddbcee553ca5f29bf16 >Author: John F. Carr <jfc@mit.edu> >Date: Sun Aug 27 08:59:12 2023 -0400 > > Do not free memory with spinlock held > >diff --git a/sys/dev/smartpqi/smartpqi_discovery.c b/sys/dev/smartpqi/smartpqi_discovery.c >index 7e084a81cd89..264b83d01280 100644 >--- a/sys/dev/smartpqi/smartpqi_discovery.c >+++ b/sys/dev/smartpqi/smartpqi_discovery.c >@@ -1671,10 +1671,12 @@ pqisrc_free_device(pqisrc_softstate_t * softs, pqi_scsi_dev_t *device) > pqisrc_delete_softs_entry(softs, device); > DBG_NOTE("Removed memory for device : B %d: T %d: L %d\n", > device->bus, device->target, device->lun); >+ OS_RELEASE_SPINLOCK(&softs->devlist_lock); > pqisrc_device_mem_free(softs, device); > } >- >- OS_RELEASE_SPINLOCK(&softs->devlist_lock); >+ else { >+ OS_RELEASE_SPINLOCK(&softs->devlist_lock); >+ } > > } >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=244386">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 273289
:
244283
| 244386