Attachment 244703 Details for Bug 268393 – patch

[patch] patch

1712c18f78.patch (text/plain), 1.18 KB, created by Ivan Rozhuk on 2023-09-07 23:03:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Rozhuk

Created: 2023-09-07 23:03:02 UTC

Size: 1.18 KB

patch

obsolete

>From 1712c18f78326ade0f37971b51326096fb05a796 Mon Sep 17 00:00:00 2001
>From: Rozhuk Ivan <rozhuk.im@gmail.com>
>Date: Fri, 8 Sep 2023 02:00:49 +0300
>Subject: [PATCH] sound/pci/hda: fix crash on first system boot after power on.
>
>Regress after: https://reviews.freebsd.org/D34117
>PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268393
>---
> sys/dev/sound/pci/hda/hdac.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/sys/dev/sound/pci/hda/hdac.c b/sys/dev/sound/pci/hda/hdac.c
>index 82b1baacfa9..0daf00009f8 100644
>--- a/sys/dev/sound/pci/hda/hdac.c
>+++ b/sys/dev/sound/pci/hda/hdac.c
>@@ -956,6 +956,8 @@ hdac_rirb_flush(struct hdac_softc *sc)
> 	int ret;
> 
> 	rirb_base = (struct hdac_rirb *)sc->rirb_dma.dma_vaddr;
>+	if (rirb_base == NULL)
>+		return (0);
> 	rirbwp = HDAC_READ_1(&sc->mem, HDAC_RIRBWP);
> 	bus_dmamap_sync(sc->rirb_dma.dma_tag, sc->rirb_dma.dma_map,
> 	    BUS_DMASYNC_POSTREAD);
>@@ -965,6 +967,8 @@ hdac_rirb_flush(struct hdac_softc *sc)
> 		sc->rirb_rp++;
> 		sc->rirb_rp %= sc->rirb_size;
> 		rirb = &rirb_base[sc->rirb_rp];
>+		if (rirb == NULL)
>+			continue;
> 		resp = le32toh(rirb->response);
> 		resp_ex = le32toh(rirb->response_ex);
> 		cad = HDAC_RIRB_RESPONSE_EX_SDATA_IN(resp_ex);

Actions: View | Diff

Attachments on bug 268393: 238814 | 238815 | 238816 | 238817 | 240519 | 240520 | 240521 | 240647 | 240800 | 240801 | 240909 | 240910 | 241040 | 241393 | 241394 | 241460 | 241461 | 241709 | 243289 | 243290 | 243291 | 244703