Attachment 245237 Details for Bug 274092 – git diff to use ether_gen_addr

[patch] git diff to use ether_gen_addr

if_smsc.c.diff (text/plain), 1013 bytes, created by Ronald Klop on 2023-09-25 22:02:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ronald Klop

Created: 2023-09-25 22:02:39 UTC

Size: 1013 bytes

patch

obsolete

>diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/usb/net/if_smsc.c
>index 0a0268bfa1a2..157f268ef4dd 100644
>--- a/sys/dev/usb/net/if_smsc.c
>+++ b/sys/dev/usb/net/if_smsc.c
>@@ -1554,8 +1554,11 @@ static void
> smsc_attach_post(struct usb_ether *ue)
> {
> 	struct smsc_softc *sc = uether_getsc(ue);
>+	struct ether_addr eaddr;
>+	if_t ifp;
> 	uint32_t mac_h, mac_l;
> 	int err;
>+	int i;
> 
> 	smsc_dbg_printf(sc, "smsc_attach_post\n");
> 
>@@ -1589,9 +1592,10 @@ smsc_attach_post(struct usb_ether *ue)
> 			err = usb_fdt_get_mac_addr(sc->sc_ue.ue_dev, &sc->sc_ue);
> #endif
> 		if ((err != 0) || (!ETHER_IS_VALID(sc->sc_ue.ue_eaddr))) {
>-			read_random(sc->sc_ue.ue_eaddr, ETHER_ADDR_LEN);
>-			sc->sc_ue.ue_eaddr[0] &= ~0x01;     /* unicast */
>-			sc->sc_ue.ue_eaddr[0] |=  0x02;     /* locally administered */
>+			device_printf(ue->ue_dev, "No MAC address found. Using ether_gen_addr().\n");
>+			ether_gen_addr(ue->ue_ifp, &eaddr);
>+			for (i = 0; i < ETHER_ADDR_LEN; i++)
>+				sc->sc_ue.ue_eaddr[i] = eaddr.octet[i];
> 		}
> 	}
>

Actions: View | Diff

Attachments on bug 274092: 245237 | 245239 | 245577 | 245603 | 245616 | 246108 | 246128 | 246231