Attachment 253304 Details for Bug 247528 – Reformatted RTL8188EU patch.

[patch] Reformatted RTL8188EU patch.

0002-rtwn-Fix-RTL8188EU-cannot-associate-in-STA-mode.patch (text/plain), 2.67 KB, created by Cy Schubert on 2024-09-03 20:02:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Cy Schubert

Created: 2024-09-03 20:02:17 UTC

Size: 2.67 KB

patch

obsolete

>From a606d7b900a64adf4fa3ea5194c8fb2e41354289 Mon Sep 17 00:00:00 2001
>From: Cy Schubert <cy@FreeBSD.org>
>Date: Thu, 2 Mar 2023 09:31:27 -0800
>Subject: [PATCH 2/2] rtwn: Fix RTL8188EU cannot associate in STA mode
>
>As with RTL8192EU a user reported that the RTL8188EU has identical
>problems. Apply a similar fix to this chipset too.
>others it will work fine. On the systems RTL8192EU fails to associate
>in STA mode, it works perfectly fine in AP mode. This points to a USB
>timing issue when selecting a channel while in STA mode.
>
>PR:		247528
>Reported by:	rkoberman@gmail.com
>MFC after:	2 weeks
>Differential Revision:	https://reviews.freebsd.org/D38854
>---
> sys/dev/rtwn/rtl8188e/r88e_reg.h       |  1 +
> sys/dev/rtwn/rtl8188e/usb/r88eu_init.c | 15 ++++++++++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
>diff --git a/sys/dev/rtwn/rtl8188e/r88e_reg.h b/sys/dev/rtwn/rtl8188e/r88e_reg.h
>index d9f236cddbb6..bed88c4604f6 100644
>--- a/sys/dev/rtwn/rtl8188e/r88e_reg.h
>+++ b/sys/dev/rtwn/rtl8188e/r88e_reg.h
>@@ -121,5 +121,6 @@
> 
> /* Bits for R88E_XCK_OUT_CTRL. */
> #define R88E_XCK_OUT_CTRL_EN	1
>+#define R88E_USB_DELAY_US_DEF	1000
> 
> #endif	/* R88E_REG_H */
>diff --git a/sys/dev/rtwn/rtl8188e/usb/r88eu_init.c b/sys/dev/rtwn/rtl8188e/usb/r88eu_init.c
>index f4f936493cda..510a820b71ad 100644
>--- a/sys/dev/rtwn/rtl8188e/usb/r88eu_init.c
>+++ b/sys/dev/rtwn/rtl8188e/usb/r88eu_init.c
>@@ -48,6 +48,8 @@
> #include <dev/rtwn/rtl8192c/r92c.h>
> #include <dev/rtwn/rtl8192c/r92c_var.h>
> 
>+#include <dev/rtwn/usb/rtwn_usb_var.h>
>+
> #include <dev/rtwn/rtl8188e/usb/r88eu.h>
> #include <dev/rtwn/rtl8188e/usb/r88eu_reg.h>
> 
>@@ -76,8 +78,12 @@ r88eu_power_on(struct rtwn_softc *sc)
> 	if (res != 0)		\
> 		return (EIO);	\
> } while(0)
>+	struct rtwn_usb_softc *uc;
> 	int ntries;
> 
>+	if ((uc = RTWN_USB_SOFTC(sc)) != NULL)
>+		uc->uc_write_delay = 1;
>+
> 	/* Wait for power ready bit. */
> 	for (ntries = 0; ntries < 5000; ntries++) {
> 		if (rtwn_read_4(sc, R92C_APS_FSMCO) & R92C_APS_FSMCO_SUS_HOST)
>@@ -85,6 +91,8 @@ r88eu_power_on(struct rtwn_softc *sc)
> 		rtwn_delay(sc, 10);
> 	}
> 	if (ntries == 5000) {
>+		if (uc != NULL)
>+			uc->uc_write_delay = 0;
> 		device_printf(sc->sc_dev,
> 		    "timeout waiting for chip power up\n");
> 		return (ETIMEDOUT);
>@@ -112,7 +120,10 @@ r88eu_power_on(struct rtwn_softc *sc)
> 			break;
> 		rtwn_delay(sc, 10);
> 	}
>-	if (ntries == 5000)
>+	if (ntries == 5000) {
>+		if (uc != NULL)
>+			uc->uc_write_delay = 0;
>+	}
> 		return (ETIMEDOUT);
> 
> 	/* Enable LDO normal mode. */
>@@ -128,6 +139,8 @@ r88eu_power_on(struct rtwn_softc *sc)
> 	    ((sc->sc_hwcrypto != RTWN_CRYPTO_SW) ? R92C_CR_ENSEC : 0) |
> 	    R92C_CR_CALTMR_EN));
> 
>+	if (uc != NULL)
>+		uc->uc_write_delay = 0;
> 	return (0);
> #undef RTWN_CHK
> }
>-- 
>2.46.0
>

Actions: View | Diff

Attachments on bug 247528: 239366 | 239399 | 239429 | 239455 | 240612 | 253233 | 253264 | 253301 | 253303 | 253304