Attachment 253436 Details for Bug 281279 – Initialize previously uninitialized fields in nfsv4_loadattr

[patch] Initialize previously uninitialized fields in nfsv4_loadattr

0001-nfscl-fix-uninitialized-memory-in-nfsv4_loadattr.patch (text/plain), 1.04 KB, created by Alan Somers on 2024-09-08 20:50:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alan Somers

Created: 2024-09-08 20:50:03 UTC

Size: 1.04 KB

patch

obsolete

>From dee707cb443a8da6a12bb4382ed5ad87a90bab4c Mon Sep 17 00:00:00 2001
>From: Alan Somers <asomers@FreeBSD.org>
>Date: Sun, 8 Sep 2024 14:42:38 -0600
>Subject: [PATCH] nfscl: fix uninitialized memory in nfsv4_loadattr
>
>When processing an RPC response that did not include any Owner
>attribute, nfsv4_loadattr would return na_uid and na_gid uninitialized.
>The uninitialized values could then make their way into the NFS
>attribute cache via nfscl_loadattrcache.
>
>PR:		281279
>Reported by:	KMSAN
>MFC after:	2 weeks
>Sponsored by:	Axcient
>---
> sys/fs/nfs/nfs_commonsubs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/sys/fs/nfs/nfs_commonsubs.c b/sys/fs/nfs/nfs_commonsubs.c
>index f0469958a43f..ec214f03adf0 100644
>--- a/sys/fs/nfs/nfs_commonsubs.c
>+++ b/sys/fs/nfs/nfs_commonsubs.c
>@@ -1332,6 +1332,8 @@ nfsv4_loadattr(struct nfsrv_descript *nd, vnode_t vp,
> 			nap->na_gen = 0;
> 			nap->na_flags = 0;
> 			nap->na_blocksize = NFS_FABLKSIZE;
>+			nap->na_uid = VNOVAL;
>+			nap->na_gid = VNOVAL;
> 		}
> 		if (sbp != NULL) {
> 			sbp->f_bsize = NFS_FABLKSIZE;
>-- 
>2.45.2
>

Flags:

asomers: maintainer-approval? (rmacklem)

Actions: View | Diff

Attachments on bug 281279: 253436