Attachment 255630 Details for Bug 283131 – security/heimdal: fix with stock clang >= 16

[patch] security/heimdal: fix with stock clang >= 16

security__heimdal-fix-stock-clang16-build-1.diff (text/plain), 1.31 KB, created by Dimitry Andric on 2024-12-04 18:50:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2024-12-04 18:50:14 UTC

Size: 1.31 KB

patch

obsolete

>commit a33b02bea99a84e6ec230fd742818eb11604211c
>Author: Dimitry Andric <dim@FreeBSD.org>
>Date:   2024-12-04T19:49:29+01:00
>
>    security/heimdal: fix with stock clang >= 16
>    
>    Upstream clang >= 16 made -Wimplicit-function-declaration into an error
>    by default. In the base system, this change was reverted to reduce the
>    fallout in ports, because there are many problematic configure scripts.
>    
>    For security/heimdal this also applies, so for building the port with
>    devel/llvm16 or higher we need to add -Wno-implicit-function-declaration
>    to CFLAGS.
>    
>    While here, use LDFLAGS+= for -Wl,--undefined-version, to avoid
>    overwriting any user-specified LDFLAGS.
>    
>    PR:             283131
>    MFH:            2024Q4
>
>diff --git a/security/heimdal/Makefile b/security/heimdal/Makefile
>index 3508ad2f8f0c..dae850e063f3 100644
>--- a/security/heimdal/Makefile
>+++ b/security/heimdal/Makefile
>@@ -45,7 +45,8 @@ CONFIGURE_ARGS=	--with-berkeley-db \
> 		--sysconfdir="${PREFIX}/etc"
> # XXX --with-readline picks up libreadline even if found in /usr/lib.
> MAKE_ENV=	INSTALL_CATPAGES=no
>-LDFLAGS=	-Wl,--undefined-version
>+CFLAGS+=	-Wno-implicit-function-declaration
>+LDFLAGS+=	-Wl,--undefined-version
> INSTALL_TARGET=	install-strip
> .if !exists(/etc/rc.d/ipropd_master)
> USE_RC_SUBR=	ipropd_master ipropd_slave

Actions: View | Diff

Attachments on bug 283131: 255630