Attachment 256494 Details for Bug 283900 – Proposed patch

[patch] Proposed patch

0001-sysutils-apcupsd-Increase-COMMLOST_TIMEOUT-in-pcnet..patch (text/plain), 1.46 KB, created by Steven Stallion on 2025-01-07 04:27:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Steven Stallion

Created: 2025-01-07 04:27:17 UTC

Size: 1.46 KB

patch

obsolete

>From 2db3efb6ddf8cc55e4b0ed7e18b4a931583463cc Mon Sep 17 00:00:00 2001
>From: Steven Stallion <sstallion@gmail.com>
>Date: Mon, 6 Jan 2025 22:19:31 -0600
>Subject: [PATCH] sysutils/apcupsd: Increase COMMLOST_TIMEOUT in pcnet.c
>
>The default COMMLOST_TIMEOUT is too strict for some environments. Newer
>NMC firmware releases may delay status packets by more than 60 seconds,
>which results in spurious COMMLOST events.
>
>See https://sourceforge.net/p/apcupsd/mailman/message/59114143/ for
>details.
>---
> .../files/patch-src_drivers_pcnet_pcnet.c       | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 sysutils/apcupsd/files/patch-src_drivers_pcnet_pcnet.c
>
>diff --git a/sysutils/apcupsd/files/patch-src_drivers_pcnet_pcnet.c b/sysutils/apcupsd/files/patch-src_drivers_pcnet_pcnet.c
>new file mode 100644
>index 000000000000..9e47015752ba
>--- /dev/null
>+++ b/sysutils/apcupsd/files/patch-src_drivers_pcnet_pcnet.c
>@@ -0,0 +1,17 @@
>+Index: pcnet.c
>+===================================================================
>+--- pcnet.c	(revision 2381)
>++++ pcnet.c	(working copy)
>+@@ -32,10 +32,10 @@
>+ 
>+ /*
>+  * Number of seconds with no data before we declare COMMLOST.
>+- * UPS should report in every 25 seconds. We allow 2 missing
>++ * UPS should report in every 25 seconds. We allow 3 missing
>+  * reports plus a fudge factor.
>+  */
>+-#define COMMLOST_TIMEOUT   55
>++#define COMMLOST_TIMEOUT   80
>+ 
>+ /* Win32 needs a special close for sockets */
>+ #ifdef HAVE_MINGW
>-- 
>2.46.2
>

Actions: View | Diff

Attachments on bug 283900: 256494 | 256721