Attachment 256723 Details for Bug 284089 – proposed patch

[patch] proposed patch

diff (text/plain), 1.05 KB, created by Mark Johnston on 2025-01-15 20:08:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Johnston

Created: 2025-01-15 20:08:44 UTC

Size: 1.05 KB

patch

obsolete

>commit 2326d4fcb9e74f4694cc3563139946f6b1ca8994
>Author: Mark Johnston <markj@FreeBSD.org>
>Date:   Wed Jan 15 19:59:24 2025 +0000
>
>    security/sssd2: Fix a typo in a patch
>    
>    This check was added in commit 9a40ff81f4ea ("security/sssd2:
>    Reimplement UID-finding using sysctl") and is supposed to exclude kernel
>    processes, retaining the behaviour of commit ee81c8e455ef
>    ("security/sssd2: Add patch to enumerate UIDs").
>    
>    However, it mistakenly skipped over processes with UID 0, which could
>    cause the lookup to fail.  Fix the typo.
>    
>    Sponsored by:   Klara, Inc.
>
>diff --git a/security/sssd2/files/patch-src__util__find_uid.c b/security/sssd2/files/patch-src__util__find_uid.c
>index 40f9022a5f9d..628e0312a0dc 100644
>--- a/security/sssd2/files/patch-src__util__find_uid.c
>+++ b/security/sssd2/files/patch-src__util__find_uid.c
>@@ -54,7 +54,7 @@
> +
> +    err = ENOENT;
> +    for (size_t i = 0; i < sz / sizeof(struct kinfo_proc); i++) {
>-+        if (kp[i].ki_uid == 0) {
>++        if (kp[i].ki_pid == 0) {
> +            continue;
> +        }
> +

Actions: View | Diff

Attachments on bug 284089: 256723 | 256844