Attachment 260423 Details for Bug 286699 – patch for missing thumbnails when using oxygen theme

[patch] patch for missing thumbnails when using oxygen theme

0001-fix-broken-thumbnail-generation.patch (text/plain), 3.05 KB, created by Martin Birgmeier on 2025-05-15 07:10:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Birgmeier

Created: 2025-05-15 07:10:46 UTC

Size: 3.05 KB

patch

obsolete

>From 579bdfc2d2fd5a35fb4ddb80de002fe4eb3270f6 Mon Sep 17 00:00:00 2001
>From: Martin Birgmeier <d8zNeCFG@aon.at>
>Date: Thu, 15 May 2025 09:00:22 +0200
>Subject: [PATCH] fix broken thumbnail generation
>
>https://bugs.kde.org/show_bug.cgi?id=504126
>---
> .../files/patch-thumbnail_CMakeLists.txt      | 20 +++++++++++
> .../files/patch-thumbnail_thumbnail.cpp       | 35 +++++++++++++++++++
> 2 files changed, 55 insertions(+)
> create mode 100644 devel/kio-extras/files/patch-thumbnail_CMakeLists.txt
> create mode 100644 devel/kio-extras/files/patch-thumbnail_thumbnail.cpp
>
>diff --git a/devel/kio-extras/files/patch-thumbnail_CMakeLists.txt b/devel/kio-extras/files/patch-thumbnail_CMakeLists.txt
>new file mode 100644
>index 000000000000..383d9f995abb
>--- /dev/null
>+++ b/devel/kio-extras/files/patch-thumbnail_CMakeLists.txt
>@@ -0,0 +1,20 @@
>+--- ./thumbnail/CMakeLists.txt.ORIG	2025-05-02 23:00:29.000000000 +0200
>++++ ./thumbnail/CMakeLists.txt	2025-05-15 08:46:58.948129000 +0200
>+@@ -91,13 +91,10 @@
>+ )
>+ 
>+ target_link_libraries(kio_thumbnail
>+-    PUBLIC
>+-        KF6::CoreAddons
>+-        KF6::KIOCore
>+-        KF6::KIOWidgets
>+-        KF6::I18n
>+-    PRIVATE
>+-        Qt6::GuiPrivate
>++    KF6::CoreAddons
>++    KF6::KIOCore
>++    KF6::KIOWidgets
>++    KF6::I18n
>+ )
>+ 
>+ install(TARGETS kio_thumbnail DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf6/kio)
>diff --git a/devel/kio-extras/files/patch-thumbnail_thumbnail.cpp b/devel/kio-extras/files/patch-thumbnail_thumbnail.cpp
>new file mode 100644
>index 000000000000..41ca853d9911
>--- /dev/null
>+++ b/devel/kio-extras/files/patch-thumbnail_thumbnail.cpp
>@@ -0,0 +1,35 @@
>+--- ./thumbnail/thumbnail.cpp.ORIG	2025-05-02 23:00:29.000000000 +0200
>++++ ./thumbnail/thumbnail.cpp	2025-05-15 08:47:27.460014000 +0200
>+@@ -53,9 +53,6 @@
>+ 
>+ #include "imagefilter.h"
>+ 
>+-#include <private/qguiapplication_p.h> // QGuiApplicationPrivate::platformTheme()
>+-#include <qpa/qplatformtheme.h>
>+-
>+ // Recognized metadata entries:
>+ // mimeType     - the mime type of the file, used for the overlay icon if any
>+ // width        - maximum width for the thumbnail
>+@@ -105,22 +102,6 @@
>+     // hand, this worker uses QPixmaps for some reason, and they
>+     // need QGuiApplication
>+     qunsetenv("SESSION_MANAGER");
>+-
>+-    // Some plugins may cause unwanted windows to appear
>+-    // (e.g. Webarchiver, see https://bugs.kde.org/show_bug.cgi?id=500173).
>+-    // This will not let any plugin to create auxilliary windows on the screen
>+-    // while generating thumbnails.
>+-    // Retrieve theme name from the default platform...
>+-    QString themeName;
>+-    {
>+-        QGuiApplication aux(argc, argv);
>+-        if (auto platformTheme = QGuiApplicationPrivate::platformTheme()) {
>+-            themeName = platformTheme->name();
>+-        }
>+-    }
>+-    // ...and force using offscreen platform with the default platform's theme
>+-    qputenv("QT_QPA_PLATFORM", "offscreen");
>+-    qputenv("QT_QPA_PLATFORMTHEME", themeName.toUtf8());
>+ 
>+     // Some thumbnail plugins use QWidget classes for the rendering,
>+     // so use QApplication here, not just QGuiApplication
>-- 
>2.49.0
>

Actions: View | Diff

Attachments on bug 286699: 260423