Attachment 92572 Details for Bug 130236 – patch-pbl

patch-pbl

patch-pbl (text/plain), 1.01 KB, created by consulting on 2009-10-01 17:19:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: consulting

Created: 2009-10-01 17:19:46 UTC

Size: 1.01 KB

patch

obsolete

>The first hunk is needed because one of the PBL-functions wrapped
>by throw_on_error returns long, rather than int -- pblKfFind()
>
>For some reason -- most probably, a compiler BUG -- when the result
>is -1 due to PBL_ERROR_NOT_FOUND, an exception is thrown anyway, even
>though throw_on_error() is supposed to handle that case.
>
>The second hunk reflects the changes in the libpbl API -- various
>memory-size related variables are now (correctly) of type size_t.
>
>	-mi
>
>--- src/database/FrequencyDBImpl_pbl.cc	2006-11-17 02:24:48.000000000 -0500
>+++ src/database/FrequencyDBImpl_pbl.cc	2009-09-30 16:08:39.000000000 -0400
>@@ -45,6 +45,6 @@
> const char *FrequencyDBImpl_pbl::SEARCH_SUFFIX("pkey");
> 
>-inline int throw_on_error(const char *function_name,
>-                          int rc)
>+inline long throw_on_error(const char *function_name,
>+                          long rc)
> {
>   if (rc >= 0) {
>@@ -261,6 +261,6 @@
> {
>   char key[BUFFER_SIZE];
>-  int keylen = 0;
>-  int rc = 0;
>+  size_t keylen;
>+  int rc;
> 
>   switch (pbl_code) {

Actions: View

Attachments on bug 130236: 92571 | 92572