FreeBSD Bugzilla – Attachment 142006 Details for
Bug 188951
bsdinstall(8): [patch] Undefined behavior at line 135 in part_wizard.c (snprintf).
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
file.txt
file.txt (text/plain), 537 bytes, created by
henning.petersen
on 2014-04-24 12:40:00 UTC
(
hide
)
Description:
file.txt
Filename:
MIME Type:
Creator:
henning.petersen
Created:
2014-04-24 12:40:00 UTC
Size:
537 bytes
patch
obsolete
>--- usr.sbin/bsdinstall/partedit/part_wizard.c (revision 264867) >+++ usr.sbin/bsdinstall/partedit/part_wizard.c (working copy) >@@ -130,9 +130,13 @@ > else > strcat(diskdesc, " Disk"); > >- if (desc != NULL) >- snprintf(diskdesc, sizeof(diskdesc), >- "%s <%s>", diskdesc, desc); >+ if (desc != NULL) { >+ size_t len; >+ len = strlen(diskdesc); >+ snprintf(diskdesc + len, >+ sizeof(diskdesc) - len, >+ " <%s>", desc); >+ } > > disks[n-1].text = strdup(diskdesc); > disks[n-1].help = NULL;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=142006">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 188951
: 142006