Attachment 160839 Details for Bug 202951 – v1 + commit message

[patch] v1 + commit message

osmium.doxygen.diff (text/plain), 1.11 KB, created by Jan Beich on 2015-09-08 15:49:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Beich

Created: 2015-09-08 15:49:13 UTC

Size: 1.11 KB

patch

obsolete

>From 0010103e4c0fd1118a48e33e0aff45958ba2d165 Mon Sep 17 00:00:00 2001
>From: Jan Beich <jbeich@FreeBSD.org>
>Date: Tue, 8 Sep 2015 15:44:51 +0000
>Subject: astro/osmium: unbreak build with DOXYGEN=on after r394778
>
>NO_BUILD does more than dummy do-build. It creates BUILD_COOKIE that marks
>all targets in _BUILD_SEQ as done, including do-build-${opt}-on/off and
>post-build-${opt}-on/off. Since the targets haven't been run yet
>do-install-DOXYGEN-on fails due to missing files.
>
>Fix by leaking a call to nop "all" target in vendor Makefile. It should
>be less kludgy than defining our own dummy do-build and less confusing
>than treating do-build itself as an option helper. In case vendor "all"
>starts doing something useful the port would automatically take
>advantage of it.
>
>PR:		202951
>Reviewed by:	mat ?
>Approved by:	portmgr blanket
>
>diff --git astro/osmium/Makefile astro/osmium/Makefile
>index b180fb2..261d5e2 100644
>--- astro/osmium/Makefile
>+++ astro/osmium/Makefile
>@@ -29,7 +29,6 @@ CXXFLAGS+=	-I${LOCALBASE}/include \
> 		-L${LOCALBASE}/lib
> 
> NO_ARCH=	yes
>-NO_BUILD=	yes
> PORTDOCS=	*
> 
> OPTIONS_DEFINE=	JAVASCRIPT DOXYGEN DOCS

Flags:

jbeich: maintainer-approval? (mat)

Actions: View | Diff

Attachments on bug 202951: 160805 | 160806 | 160807 | 160839 | 160840 | 160841