Attachment #161051 for bug #203121

View | Details | Raw Unified | Return to bug 203121
Collapse All | Expand All




# $FreeBSD$

PORTNAME=	libinotify
PORTVERSION=	20150910
CATEGORIES=	devel

MAINTAINER=	delphij@FreeBSD.org

USE_GITHUB=	yes
GH_ACCOUNT=	dmatveev
GH_PROJECT=	libinotify-kqueue
GH_TAGNAME=	b2873cf

USES=		autoreconf libtool
GNU_CONFIGURE=	yes
USE_LDCONFIG=	yes
INSTALL_TARGET=	install-strip

post-patch:
	@${CP} ${FILESDIR}/Makefile ${WRKSRC}
	@${TOUCH} ${WRKSRC}/config.h
	@echo "#define HAVE_PTHREAD_BARRIER 1" >> ${WRKSRC}/config.h
	@echo "#define BUILD_LIBRARY 1" >> ${WRKSRC}/config.h
	@echo "#include <sys/tree.h>" >> ${WRKSRC}/config.h

.include <bsd.port.mk>

Lines 1-2 Link Here

(-)distinfo (-2 / +2 lines)
1	SHA256 (dmatveev-libinotify-kqueue-20150516-f4a092a_GH0.tar.gz) = ad001b8229e83d379d41c0add348cff97b50c07ce60cf3f78aff86ddd18bdda3	1	SHA256 (dmatveev-libinotify-kqueue-20150910-b2873cf_GH0.tar.gz) = 40672e27c8ea609ae79b370f0a6ac7a72ab9d1d9fc34ae5333980e612a337f19
2	SIZE (dmatveev-libinotify-kqueue-20150516-f4a092a_GH0.tar.gz) = 42543	2	SIZE (dmatveev-libinotify-kqueue-20150910-b2873cf_GH0.tar.gz) = 61578




# $FreeBSD$

SHLIB=		inotify
SHLIB_MAJOR=	0

DPADD=		${LIBPTHREAD}
LDADD=		-lpthread

SRCS=		utils.c
SRCS+=		compat.c
SRCS+=		conversions.c
SRCS+=		dep-list.c
SRCS+=		inotify-watch.c
SRCS+=		watch-set.c
SRCS+=		watch.c
SRCS+=		worker-thread.c
SRCS+=		worker.c
SRCS+=		controller.c

INCS=		sys/inotify.h

CFLAGS+=	-I${.CURDIR} -DNDEBUG -pthread

LIBDIR=		${PREFIX}/lib
INCLUDEDIR=	${PREFIX}/include/sys

LIBOWN!=	id -un
LIBGRP!=	id -gn
BINOWN=		${LIBOWN}
BINGRP=		${LIBGRP}

beforeinstall:
	@mkdir -p ${DESTDIR}/${LIBDIR} ${DESTDIR}/${INCLUDEDIR}

.include <bsd.lib.mk>




============================================================================

Libinotify functionality on FreeBSD is missing support for

  - detecting a file being moved into or out of a directory within the
    same filesystem
  - certain modifications to a symbolic link (rather than the
    file it points to.)

in addition to the known limitations on all platforms using kqueue(2)
where various open and close notifications are unimplemented.

This means the following regression tests will fail:

Directory notifications:
   IN_MOVED_FROM
   IN_MOVED_TO
   
Open/close notifications:
   IN_OPEN
   IN_CLOSE_NOWRITE
   IN_CLOSE_WRITE
   
Symbolic Link notifications:
   IN_DONT_FOLLOW
   IN_ATTRIB
   IN_MOVE_SELF
   IN_DELETE_SELF

Kernel patches to address the missing directory and symbolic link
notifications are available from:

https://github.com/dmatveev/libinotify-kqueue/tree/master/patches

=============================================================================
You might want to consider increasing the kern.maxfiles tunable if you plan
to use this library for applications that need to monitor activity of a lot
of files.

If the default on your system is too low, add the following line to
/boot/loader.conf, then reboot the system:

    kern.maxfiles="25000"
=============================================================================

Lines 1-3 Link Here

(-)pkg-plist (+2 lines)
1	include/sys/inotify.h	1	include/sys/inotify.h
		2	lib/libinotify.a
2	lib/libinotify.so	3	lib/libinotify.so
3	lib/libinotify.so.0	4	lib/libinotify.so.0
		5	lib/libinotify.so.0.0.0

Return to bug 203121

Lines 2-8 Link Here

(-)Makefile (-9 / +5 lines)
2	# $FreeBSD$	2	# $FreeBSD$
3		3
4	PORTNAME= libinotify	4	PORTNAME= libinotify
5	PORTVERSION= 20150516	5	PORTVERSION= 20150910
6	CATEGORIES= devel	6	CATEGORIES= devel
7		7
8	MAINTAINER= delphij@FreeBSD.org	8	MAINTAINER= delphij@FreeBSD.org
Lines 13-27 Link Here
13	USE_GITHUB= yes	13	USE_GITHUB= yes
14	GH_ACCOUNT= dmatveev	14	GH_ACCOUNT= dmatveev
15	GH_PROJECT= libinotify-kqueue	15	GH_PROJECT= libinotify-kqueue
16	GH_TAGNAME= f4a092a	16	GH_TAGNAME= b2873cf
17		17
		18	USES= autoreconf libtool
		19	GNU_CONFIGURE= yes
18	USE_LDCONFIG= yes	20	USE_LDCONFIG= yes
		21	INSTALL_TARGET= install-strip
19		22
20	post-patch:
21	@${CP} ${FILESDIR}/Makefile ${WRKSRC}
22	@${TOUCH} ${WRKSRC}/config.h
23	@echo "#define HAVE_PTHREAD_BARRIER 1" >> ${WRKSRC}/config.h
24	@echo "#define BUILD_LIBRARY 1" >> ${WRKSRC}/config.h
25	@echo "#include <sys/tree.h>" >> ${WRKSRC}/config.h
26
27	.include <bsd.port.mk>	23	.include <bsd.port.mk>

Lines 1-35 Link Here

(-)files/Makefile (-35 lines)
1	# $FreeBSD$
2
3	SHLIB= inotify
4	SHLIB_MAJOR= 0
5
6	DPADD= ${LIBPTHREAD}
7	LDADD= -lpthread
8
9	SRCS= utils.c
10	SRCS+= compat.c
11	SRCS+= conversions.c
12	SRCS+= dep-list.c
13	SRCS+= inotify-watch.c
14	SRCS+= watch-set.c
15	SRCS+= watch.c
16	SRCS+= worker-thread.c
17	SRCS+= worker.c
18	SRCS+= controller.c
19
20	INCS= sys/inotify.h
21
22	CFLAGS+= -I${.CURDIR} -DNDEBUG -pthread
23
24	LIBDIR= ${PREFIX}/lib
25	INCLUDEDIR= ${PREFIX}/include/sys
26
27	LIBOWN!= id -un
28	LIBGRP!= id -gn
29	BINOWN= ${LIBOWN}
30	BINGRP= ${LIBGRP}
31
32	beforeinstall:
33	@mkdir -p ${DESTDIR}/${LIBDIR} ${DESTDIR}/${INCLUDEDIR}
34
35	.include <bsd.lib.mk>

Lines 1-10 Link Here

(-)pkg-message (-2 / +36 lines)
1	============================================================================	1	============================================================================
		2
		3	Libinotify functionality on FreeBSD is missing support for
		4
		5	- detecting a file being moved into or out of a directory within the
		6	same filesystem
		7	- certain modifications to a symbolic link (rather than the
		8	file it points to.)
		9
		10	in addition to the known limitations on all platforms using kqueue(2)
		11	where various open and close notifications are unimplemented.
		12
		13	This means the following regression tests will fail:
		14
		15	Directory notifications:
		16	IN_MOVED_FROM
		17	IN_MOVED_TO
		18
		19	Open/close notifications:
		20	IN_OPEN
		21	IN_CLOSE_NOWRITE
		22	IN_CLOSE_WRITE
		23
		24	Symbolic Link notifications:
		25	IN_DONT_FOLLOW
		26	IN_ATTRIB
		27	IN_MOVE_SELF
		28	IN_DELETE_SELF
		29
		30	Kernel patches to address the missing directory and symbolic link
		31	notifications are available from:
		32
		33	https://github.com/dmatveev/libinotify-kqueue/tree/master/patches
		34
		35	=============================================================================
2	You might want to consider increasing the kern.maxfiles tunable if you plan	36	You might want to consider increasing the kern.maxfiles tunable if you plan
3	to use this library for applications that need to monitor activity of a lot	37	to use this library for applications that need to monitor activity of a lot
4	of files.	38	of files.
5		39
6	For a typical desktop, add the following line to /boot/loader.conf, then	40	If the default on your system is too low, add the following line to
7	reboot the system:	41	/boot/loader.conf, then reboot the system:
8		42
9	kern.maxfiles="25000"	43	kern.maxfiles="25000"
10	=============================================================================	44	=============================================================================