View | Details | Raw Unified | Return to bug 203154
Collapse All | Expand All

(-)databases/rocksdb/files/patch-db-db_bench.cc (+21 lines)
Line 0 Link Here
1
--- db/db_bench.cc.orig	2015-08-31 20:23:39.000000000 +0200
2
+++ db/db_bench.cc	2015-09-08 00:15:47.039650000 +0200
3
@@ -2259,8 +2259,7 @@ class Benchmark {
4
         fprintf(stderr, "Open flash device failed\n");
5
         exit(1);
6
       }
7
-      flashcache_aware_env_ =
8
-          std::move(NewFlashcacheAwareEnv(FLAGS_env, cachedev_fd_));
9
+      flashcache_aware_env_ = NewFlashcacheAwareEnv(FLAGS_env, cachedev_fd_);
10
       if (flashcache_aware_env_.get() == nullptr) {
11
         fprintf(stderr, "Failed to open flashcahce device at %s\n",
12
                 FLAGS_flashcache_dev.c_str());
13
@@ -2884,7 +2883,7 @@ class Benchmark {
14
     std::vector<std::unique_ptr<const char[]> > key_guards;
15
     std::vector<std::string> values(entries_per_batch_);
16
     while (static_cast<int64_t>(keys.size()) < entries_per_batch_) {
17
-      key_guards.push_back(std::move(std::unique_ptr<const char[]>()));
18
+      key_guards.push_back(std::unique_ptr<const char[]>());
19
       keys.push_back(AllocateKey(&key_guards.back()));
20
     }
21
 
(-)databases/rocksdb/files/patch-db-wal_manager.cc (+13 lines)
Line 0 Link Here
1
--- db/wal_manager.cc.orig	2015-08-31 20:23:39.000000000 +0200
2
+++ db/wal_manager.cc	2015-09-07 23:52:03.849468000 +0200
3
@@ -329,8 +329,8 @@ Status WalManager::GetSortedWalsOfType(c
4
         return s;
5
       }
6
 
7
-      log_files.push_back(std::move(std::unique_ptr<LogFile>(
8
-          new LogFileImpl(number, log_type, sequence, size_bytes))));
9
+      log_files.push_back(std::unique_ptr<LogFile>(
10
+          new LogFileImpl(number, log_type, sequence, size_bytes)));
11
     }
12
   }
13
   CompareLogByPointer compare_log_files;
(-)databases/rocksdb/files/patch-tools-db_stress.cc (+11 lines)
Line 0 Link Here
1
--- tools/db_stress.cc.orig	2015-08-31 20:23:39.000000000 +0200
2
+++ tools/db_stress.cc	2015-09-16 14:31:58.271646000 +0200
3
@@ -222,7 +222,7 @@ DEFINE_int32(set_options_one_in, 0,
4
 DEFINE_int32(set_in_place_one_in, 0,
5
              "With a chance of 1/N, toggle in place support option");
6
 
7
-DEFINE_int64(cache_size, 2 * KB * KB * KB,
8
+DEFINE_int64(cache_size, static_cast<int64_t>(2) * KB * KB * KB,
9
              "Number of bytes to use as a cache of uncompressed data.");
10
 
11
 static bool ValidateInt32Positive(const char* flagname, int32_t value) {
(-)databases/rocksdb/files/patch-util-sst_dump_tool.cc (+11 lines)
Line 0 Link Here
1
--- util/sst_dump_tool.cc.orig	2015-08-31 20:23:39.000000000 +0200
2
+++ util/sst_dump_tool.cc	2015-09-08 00:07:36.564981000 +0200
3
@@ -164,7 +164,7 @@ int SstFileReader::ShowAllCompressionSiz
4
   compress_type.insert(
5
       std::make_pair(CompressionType::kLZ4HCCompression, "kLZ4HCCompression"));
6
 
7
-  fprintf(stdout, "Block Size: %lu\n", block_size);
8
+  fprintf(stdout, "Block Size: %zu\n", block_size);
9
 
10
   for (CompressionType i = CompressionType::kNoCompression;
11
        i != CompressionType::kLZ4HCCompression; i = CompressionType(i + 1)) {
(-)databases/rocksdb/files/patch-utilities-backupable-backupable_db.cc (+28 lines)
Line 0 Link Here
1
--- utilities/backupable/backupable_db.cc.orig	2015-08-31 20:23:39.000000000 +0200
2
+++ utilities/backupable/backupable_db.cc	2015-09-08 00:08:37.375425000 +0200
3
@@ -560,10 +560,10 @@ Status BackupEngineImpl::Initialize() {
4
       continue;
5
     }
6
     assert(backups_.find(backup_id) == backups_.end());
7
-    backups_.insert(std::move(
8
+    backups_.insert(
9
         std::make_pair(backup_id, unique_ptr<BackupMeta>(new BackupMeta(
10
                                       GetBackupMetaFile(backup_id),
11
-                                      &backuped_file_infos_, backup_env_)))));
12
+                                      &backuped_file_infos_, backup_env_))));
13
   }
14
 
15
   if (options_.destroy_old_data) {  // Destroy old data
16
@@ -701,10 +701,10 @@ Status BackupEngineImpl::CreateNewBackup
17
 
18
   BackupID new_backup_id = latest_backup_id_ + 1;
19
   assert(backups_.find(new_backup_id) == backups_.end());
20
-  auto ret = backups_.insert(std::move(
21
+  auto ret = backups_.insert(
22
       std::make_pair(new_backup_id, unique_ptr<BackupMeta>(new BackupMeta(
23
                                         GetBackupMetaFile(new_backup_id),
24
-                                        &backuped_file_infos_, backup_env_)))));
25
+                                        &backuped_file_infos_, backup_env_))));
26
   assert(ret.second == true);
27
   auto& new_backup = ret.first->second;
28
   new_backup->RecordTimestamp();
(-)databases/rocksdb/files/patch-utilities-checkpoint-checkpoint.cc (+11 lines)
Line 0 Link Here
1
--- utilities/checkpoint/checkpoint.cc.orig	2015-08-31 20:23:39.000000000 +0200
2
+++ utilities/checkpoint/checkpoint.cc	2015-09-08 00:05:26.049545000 +0200
3
@@ -131,7 +131,7 @@ Status CheckpointImpl::CreateCheckpoint(
4
                    (type == kDescriptorFile) ? manifest_file_size : 0);
5
     }
6
   }
7
-  Log(db_->GetOptions().info_log, "Number of log files %ld",
8
+  Log(db_->GetOptions().info_log, "Number of log files %zu",
9
       live_wal_files.size());
10
 
11
   // Link WAL files. Copy exact size of last one because it is the only one
(-)databases/rocksdb/files/patch-utilities-document-json_document.cc (+20 lines)
Line 0 Link Here
1
--- utilities/document/json_document.cc.orig	2015-08-31 20:23:39.000000000 +0200
2
+++ utilities/document/json_document.cc	2015-09-08 00:10:06.250157000 +0200
3
@@ -307,7 +307,7 @@ JSONDocument JSONDocument::operator[](co
4
   assert(foundValue != nullptr);
5
   // No need to save paths in const objects
6
   JSONDocument ans(foundValue, false);
7
-  return std::move(ans);
8
+  return ans;
9
 }
10
 
11
 size_t JSONDocument::Count() const {
12
@@ -330,7 +330,7 @@ JSONDocument JSONDocument::operator[](si
13
   auto arrayVal = reinterpret_cast<fbson::ArrayVal*>(value_);
14
   auto foundValue = arrayVal->get(static_cast<int>(i));
15
   JSONDocument ans(foundValue, false);
16
-  return std::move(ans);
17
+  return ans;
18
 }
19
 
20
 bool JSONDocument::IsNull() const {

Return to bug 203154