Attachment 161737 Details for Bug 203563 – patch for dialog_remove_buttons, open/save dialog crashes

[patch] patch for dialog_remove_buttons, open/save dialog crashes

SalGtkFilePicker.cxx.patch (text/plain), 1.00 KB, created by Tomasz Sowa on 2015-10-05 20:24:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomasz Sowa

Created: 2015-10-05 20:24:39 UTC

Size: 1.00 KB

patch

obsolete

>diff -ur work.orig/libreoffice-5.0.2.2/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx work/libreoffice-5.0.2.2/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
>--- work.orig/libreoffice-5.0.2.2/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx	2015-10-05 19:19:56.189936000 +0200
>+++ work/libreoffice-5.0.2.2/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx	2015-10-05 19:22:28.876627000 +0200
>@@ -421,13 +421,18 @@
> static void
> dialog_remove_buttons(GtkWidget *pActionArea)
> {
>-    GList *pChildren =
>-        gtk_container_get_children( GTK_CONTAINER( pActionArea ) );
>+    GtkContainer * container = GTK_CONTAINER( pActionArea );
> 
>-    for( GList *p = pChildren; p; p = p->next )
>-        gtk_widget_destroy( GTK_WIDGET( p->data ) );
>+    if( container )
>+    {
>+        GList *pChildren =
>+            gtk_container_get_children( container );
>+
>+        for( GList *p = pChildren; p; p = p->next )
>+            gtk_widget_destroy( GTK_WIDGET( p->data ) );
> 
>-    g_list_free( pChildren );
>+        g_list_free( pChildren );
>+    }
> }
> 
> static void

Actions: View | Diff

Attachments on bug 203563: 161737 | 164277 | 179545 | 179547 | 179729 | 179731