Attachment 165293 Details for Bug 206059 – Allow inode size < sizeof(struct ext2fs_dinode) when EXT2F_ROCOMPAT_EXTRA_ISIZE is set

[patch] Allow inode size < sizeof(struct ext2fs_dinode) when EXT2F_ROCOMPAT_EXTRA_ISIZE is set

ext4-small-filesystems.txt (text/plain), 998 bytes, created by Damjan Jovanovic on 2016-01-09 07:51:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Damjan Jovanovic

Created: 2016-01-09 07:51:22 UTC

Size: 998 bytes

patch

obsolete

>commit d7d63f6919b6f31586d5f5cbcc0f2739dab38562
>Author: Damjan Jovanovic <damjan.jov@gmail.com>
>Date:   Sat Jan 9 09:26:08 2016 +0200
>
>    Don't require EXT2_INODE_SIZE(fs) < sizeof(struct ext2fs_dinode) when
>    EXT2_HAS_RO_COMPAT_FEATURE(fs, EXT2F_ROCOMPAT_EXTRA_ISIZE), as EXT4
>    filesystems < 512 MiB have EXT2F_ROCOMPAT_EXTRA_ISIZE yet fail that
>    test.
>
>diff --git a/sys/fs/ext2fs/ext2_vfsops.c b/sys/fs/ext2fs/ext2_vfsops.c
>index 5339aa2..7d0066c 100644
>--- a/sys/fs/ext2fs/ext2_vfsops.c
>+++ b/sys/fs/ext2fs/ext2_vfsops.c
>@@ -347,12 +347,6 @@ compute_sb_data(struct vnode *devvp, struct ext2fs *es,
> 			return (EIO);
> 		}
> 	}
>-	/* Check for extra isize in big inodes. */
>-	if (EXT2_HAS_RO_COMPAT_FEATURE(fs, EXT2F_ROCOMPAT_EXTRA_ISIZE) &&
>-	    EXT2_INODE_SIZE(fs) < sizeof(struct ext2fs_dinode)) {
>-		printf("ext2fs: no space for extra inode timestamps\n");
>-		return (EINVAL);
>-	}
> 
> 	fs->e2fs_ipb = fs->e2fs_bsize / EXT2_INODE_SIZE(fs);
> 	fs->e2fs_itpg = fs->e2fs_ipg / fs->e2fs_ipb;

Actions: View | Diff

Attachments on bug 206059: 165293