Attachment 16711 Details for Bug 30540 – file.diff

[patch] file.diff

file.diff (text/plain), 2.00 KB, created by Tony Finch on 2001-09-13 00:50:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tony Finch

Created: 2001-09-13 00:50:01 UTC

Size: 2.00 KB

patch

obsolete

>Index: sys/dev/kbd//atkbdc.c
>===================================================================
>RCS file: /home/ncvs/src/sys/dev/kbd/atkbdc.c,v
>retrieving revision 1.5.2.1
>diff -u -r1.5.2.1 atkbdc.c
>--- sys/dev/kbd//atkbdc.c	2000/03/31 12:51:56	1.5.2.1
>+++ sys/dev/kbd//atkbdc.c	2001/07/26 00:45:45
>@@ -217,10 +217,10 @@
>  * I/O access to the controller/keyboard/mouse. The convention requires
>  * close cooperation of the calling device driver.
>  *
>- * The device driver which utilizes the `kbdio' module are assumed to
>+ * The device drivers which utilize the `kbdio' module are assumed to
>  * have the following set of routines.
>  *    a. An interrupt handler (the bottom half of the driver).
>- *    b. Timeout routines which may briefly polls the keyboard controller.
>+ *    b. Timeout routines which may briefly poll the keyboard controller.
>  *    c. Routines outside interrupt context (the top half of the driver).
>  * They should follow the rules below:
>  *    1. The interrupt handler may assume that it always has full access 
>@@ -239,12 +239,12 @@
>  *       Therefore, `spltty()' must be strategically placed in the device
>  *       driver code. Also note that the timeout routine may interrupt
>  *       `kbdc_lock()' called by the top half of the driver, but this
>- *       interruption is OK so long as the timeout routine observes the
>- *       the rule 4 below.
>+ *       interruption is OK so long as the timeout routine observes
>+ *       rule 4 below.
>  *    4. The interrupt and timeout routines should not extend I/O operation
>- *       across more than one interrupt or timeout; they must complete
>- *       necessary I/O operation within one invokation of the routine.
>- *       This measns that if the timeout routine acquires the lock flag,
>+ *       across more than one interrupt or timeout; they must complete any
>+ *       necessary I/O operation within one invocation of the routine.
>+ *       This means that if the timeout routine acquires the lock flag,
>  *       it must reset the flag to FALSE before it returns.
>  */

Actions: View | Diff

Attachments on bug 30540: 16711