Attachment 171261 Details for Bug 210187 – patch v1

patch v1

file_210187.txt (text/plain), 1.43 KB, created by Dave Cottlehuber on 2016-06-10 09:10:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Cottlehuber

Created: 2016-06-10 09:10:53 UTC

Size: 1.43 KB

patch

obsolete

>commit af66a962569987caf85ed55b8d9938f6e4ce313b
>Author: Dave Cottlehuber <dch@skunkwerks.at>
>Date:   Fri Jun 10 10:47:40 2016 +0200
>
>    remove @ from list of invalid gecos characters so email addresses can be stored
>
>diff --git a/usr.sbin/pw/pw.8 b/usr.sbin/pw/pw.8
>index 4cf52b6..19ec3ea 100644
>--- a/usr.sbin/pw/pw.8
>+++ b/usr.sbin/pw/pw.8
>@@ -379,11 +379,11 @@ These sub-fields are used by convention only, however, and are optional.
> If this field is to contain spaces,
> the comment must be enclosed in double quotes
> .Ql \&" .
>-Avoid using commas in this field as these are used as sub-field separators,
>-and the colon
>+Commans are best avoided as these are used as sub-field separators.
>+Exclamation marks, and the colon
> .Ql \&:
>-character also cannot be used as this is the field separator for the passwd
>-file itself.
>+character are invalid. The colon character is the field separator for the
>+passwd file itself.
> .It Fl d Ar dir
> This option sets the account's home directory.
> Normally,
>diff --git a/usr.sbin/pw/pw_user.c b/usr.sbin/pw/pw_user.c
>index 67186c3..de16818 100644
>--- a/usr.sbin/pw/pw_user.c
>+++ b/usr.sbin/pw/pw_user.c
>@@ -628,7 +628,7 @@ pw_checkname(char *name, int gecos)
> 	reject = 0;
> 	if (gecos) {
> 		/* See if the name is valid as a gecos (comment) field. */
>-		badchars = ":!@";
>+		badchars = ":!";
> 		showtype = "gecos field";
> 	} else {
> 		/* See if the name is valid as a userid or group. */

Actions: View

Attachments on bug 210187: 171261