FreeBSD Bugzilla – Attachment 180766 Details for
Bug 217742
sys/dev/isci/scil/scif_sas_controller.c: PVS-Studio: Expression is Always False (CWE-570)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
git patch
scif_sas_controller.c.patch (text/plain), 695 bytes, created by
Svyatoslav
on 2017-03-13 11:46:14 UTC
(
hide
)
Description:
git patch
Filename:
MIME Type:
Creator:
Svyatoslav
Created:
2017-03-13 11:46:14 UTC
Size:
695 bytes
patch
obsolete
>diff --git a/sys/dev/isci/scil/scif_sas_controller.c b/sys/dev/isci/scil/scif_sas_controller.c >index 274dc64..a859e4e 100644 >--- a/sys/dev/isci/scil/scif_sas_controller.c >+++ b/sys/dev/isci/scil/scif_sas_controller.c >@@ -528,7 +528,7 @@ SCI_STATUS scif_user_parameters_set( > if (scif_parms->sas.is_sata_ncq_enabled != 1 && scif_parms->sas.is_sata_ncq_enabled != 0) > return SCI_FAILURE_INVALID_PARAMETER_VALUE; > >- if (scif_parms->sas.max_ncq_depth < 1 && scif_parms->sas.max_ncq_depth > 32) >+ if (scif_parms->sas.max_ncq_depth < 1 || scif_parms->sas.max_ncq_depth > 32) > return SCI_FAILURE_INVALID_PARAMETER_VALUE; > > if (scif_parms->sas.is_sata_standby_timer_enabled != 1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=180766">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 217742
: 180766