FreeBSD Bugzilla – Attachment 183567 Details for
Bug 220078
[patch] [panic] repeatable kernel panic due to unlocked INADDR_TO_IFP usage
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
lock access to INADDR_TO_IFP in the ipfw
ip_fw2.c.diff (text/plain), 835 bytes, created by
Eugene Grosbein
on 2017-06-17 12:18:07 UTC
(
hide
)
Description:
lock access to INADDR_TO_IFP in the ipfw
Filename:
MIME Type:
Creator:
Eugene Grosbein
Created:
2017-06-17 12:18:07 UTC
Size:
835 bytes
patch
obsolete
>--- sys/netpfil/ipfw/ip_fw2.c.orig 2017-06-17 17:53:48.050657000 +0700 >+++ sys/netpfil/ipfw/ip_fw2.c 2017-06-17 18:22:39.066968000 +0700 >@@ -1309,6 +1309,7 @@ do { \ > skip_or = 0; > for (l = f->cmd_len, cmd = f->cmd ; l > 0 ; > l -= cmdlen, cmd += cmdlen) { >+ struct rm_priotracker in_ifa_tracker; > int match; > > /* >@@ -1604,7 +1605,9 @@ do { \ > if (is_ipv4) { > struct ifnet *tif; > >+ IN_IFADDR_RLOCK(&in_ifa_tracker); > INADDR_TO_IFP(src_ip, tif); >+ IN_IFADDR_RUNLOCK(&in_ifa_tracker); > match = (tif != NULL); > break; > } >@@ -1643,7 +1646,9 @@ do { \ > if (is_ipv4) { > struct ifnet *tif; > >+ IN_IFADDR_RLOCK(&in_ifa_tracker); > INADDR_TO_IFP(dst_ip, tif); >+ IN_IFADDR_RUNLOCK(&in_ifa_tracker); > match = (tif != NULL); > break; > }
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=183567">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 220078
: 183567 |
183568
|
183569
|
183570
|
183590
|
187688
|
187689