Attachment 188987 Details for Bug 222122 – quote possible empty strings

[patch] quote possible empty strings

milter-opendim.diff (text/plain), 1.26 KB, created by Matthias Pfaller on 2017-12-20 09:14:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Pfaller

Created: 2017-12-20 09:14:05 UTC

Size: 1.26 KB

patch

obsolete

>--- /usr/local/etc/rc.d/milter-opendkim 2017-12-20 09:55:49.753794000 +0100
>+++ /tmp/milter-opendkim        2017-12-20 09:56:03.436497000 +0100
>@@ -178,19 +178,19 @@
> {
>     # postcmd is executed too fast and socket is not created before checking...
>     sleep 1
>-    if [ -S ${milteropendkim_socket##local:} ] ; then
>-        chmod ${_piddir_perms} ${milteropendkim_socket##local:}
>-    elif [ -S ${milteropendkim_socket##unix:} ] ; then
>-        chmod ${_piddir_perms} ${milteropendkim_socket##unix:}
>+    if [ -S "${milteropendkim_socket##local:}" ] ; then
>+        chmod ${_piddir_perms} "${milteropendkim_socket##local:}"
>+    elif [ -S "${milteropendkim_socket##unix:}" ] ; then
>+        chmod ${_piddir_perms} "${milteropendkim_socket##unix:}"
>     fi
> }
> 
> dkim_postcmd()
> {
>-    if [ -S ${milteropendkim_socket##local:} ] ; then
>-        rm -f ${milteropendkim_socket##local:}
>-    elif [ -S ${milteropendkim_socket##unix:} ] ; then
>-        rm -f ${milteropendkim_socket##unix:}
>+    if [ -S "${milteropendkim_socket##local:}" ] ; then
>+        rm -f "${milteropendkim_socket##local:}"
>+    elif [ -S "${milteropendkim_socket##unix:}" ] ; then
>+        rm -f "${milteropendkim_socket##unix:}"
>     fi
>     # just if the directory is empty
>     rmdir ${_piddir} > /dev/null 2>&1

Actions: View | Diff

Attachments on bug 222122: 188987