FreeBSD Bugzilla – Attachment 197718 Details for
Bug 231422
ports-mgmt/portlint: GH_xx lines should be acceptable in the USExx section after USE_GITHUB=yes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Updated patch
portlint.pl_GH.diff (text/plain), 1.07 KB, created by
Diane Bruce
on 2018-10-02 16:33:00 UTC
(
hide
)
Description:
Updated patch
Filename:
MIME Type:
Creator:
Diane Bruce
Created:
2018-10-02 16:33:00 UTC
Size:
1.07 KB
patch
obsolete
>--- old_portlint.pl 2018-10-01 13:39:03.616816000 -0400 >+++ portlint.pl 2018-10-02 12:25:27.735806000 -0400 >@@ -3220,6 +3220,7 @@ > print "OK: check ninth section of $file (USES: optional).\n" > if ($verbose); > $tmp = $sections[$idx] // ''; >+ my $use_github_set = 0; > > if ($tmp =~ /(USES|USE_)/) { > &checkearlier($file, $tmp, @varnames); >@@ -3232,9 +3233,25 @@ > } > if ($line =~ /USE([_\w\d]+)=[^\n]+\n/) { > print "OK: seen USE$1.\n" if ($verbose); >+ if ($tmp =~ /USE_GITHUB/) { >+ $use_github_set = 1; >+ } >+ print "OK: USE_GITHUB set\n" if($use_github_set && $verbose); > $tmp =~ s/USE([_\w\d]+)=[^\n]+\n//; > next; > } >+ } >+ print "OK: check if GH_ options are in use\n" >+ if ($verbose); >+ foreach my $line (split(/(GH(?:S[?+]|[_\w\d]+)?=[^\n]+\n)/, $tmp)) { >+ if ($line =~ /GH([_\w\d]+)=[^\n]+\n/) { >+ print "OK: seen GH$1.\n" if ($verbose); >+ print "No USE_GITHUB seen but GH$1 used\n" >+ unless ($use_github_set); >+ $tmp =~ s/GH([_\w\d]+)=[^\n]+\n//; >+ next; >+ } >+ > } > > &checkextra($tmp, 'USES/USE_x', $file);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 231422
:
197713
| 197718