Attachment 201506 Details for Bug 235296 – Patch to remove obsolete (broken) putenv() code.

[patch] Patch to remove obsolete (broken) putenv() code.

file_235296.txt (text/plain), 1.18 KB, created by topical on 2019-01-29 14:04:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: topical

Created: 2019-01-29 14:04:01 UTC

Size: 1.18 KB

patch

obsolete

>From 4b152171ae1060eb98be7b5c3583752f633fdd5c Mon Sep 17 00:00:00 2001
>From: Sean Timothy Noonan <stnoonan@obsolescence.net>
>Date: Wed, 18 Nov 2015 21:01:31 -0500
>Subject: [PATCH] Stop setting KRB5_KTNAME in environment
>
>---
> ngx_http_auth_spnego_module.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
>diff --git a/ngx_http_auth_spnego_module.c b/ngx_http_auth_spnego_module.c
>index 6d9740b..e1ce83e 100644
>--- ../spnego-http-auth-nginx-module-7e028a5/ngx_http_auth_spnego_module.c
>+++ ../spnego-http-auth-nginx-module-7e028a5/ngx_http_auth_spnego_module.c
>@@ -742,17 +742,6 @@ use_keytab(
>         ngx_http_request_t * r,
>         ngx_str_t *keytab)
> {
>-    size_t kt_env_sz = sizeof("KRB5_KTNAME=") + keytab->len;
>-    char *kt_env = (char *) ngx_pcalloc(r->pool, kt_env_sz + 1);
>-    if (NULL == kt_env) {
>-        return false;
>-    }
>-    ngx_snprintf((u_char *) kt_env, kt_env_sz, "KRB5_KTNAME=%V%Z", keytab);
>-    if (putenv(kt_env) != 0) {
>-        spnego_debug0("Failed to update environment with keytab location");
>-        return false;
>-    }
>-
>     size_t kt_sz = keytab->len + 1;
>     char *kt = (char *) ngx_pcalloc(r->pool, kt_sz);
>     if (NULL == kt) {

Actions: View | Diff

Attachments on bug 235296: 201506 | 209921 | 209922