From 00c27f542c096ad09c41dac95551346a2208e7f0 Mon Sep 17 00:00:00 2001 From: Young Xiao <92siuyang@gmail.com> Date: Tue, 11 Jun 2019 15:37:37 +0800 Subject: [PATCH] syscons: fix potential buffer overflow Use strncpy() to copy into a fixed-size buffer instead of using strcpy. Signed-off-by: Young Xiao <92siuyang@gmail.com> --- sys/dev/syscons/syscons.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/syscons/syscons.c b/sys/dev/syscons/syscons.c index 278c3c8..2ba832e 100644 --- a/sys/dev/syscons/syscons.c +++ b/sys/dev/syscons/syscons.c @@ -4262,7 +4262,8 @@ sc_allocate_keyboard(sc_softc_t *sc, int unit) continue; bzero(&ki, sizeof(ki)); - strcpy(ki.kb_name, k->kb_name); + strncpy(ki.kb_name, k->kb_name, sizeof(ki.kb_name)); + ki.kb_name[sizeof(ki.kb_name) - 1] = '\0'; ki.kb_unit = k->kb_unit; (void)kbdd_ioctl(k0, KBADDKBD, (caddr_t) &ki); -- 2.7.4