Attachment 205162 Details for Bug 238641 – The patch file

[patch] The patch file

0001-netmap-Remove-pointer-printing-in-netmap_mem2.c.patch (text/plain), 1.03 KB, created by Fuqian on 2019-06-17 06:25:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fuqian

Created: 2019-06-17 06:25:18 UTC

Size: 1.03 KB

patch

obsolete

>From 06350e789df5938e32cd0d56acc870ea2573a6e3 Mon Sep 17 00:00:00 2001
>From: Fuqian Huang <huangfq.daxian@gmail.com>
>Date: Mon, 17 Jun 2019 14:11:48 +0800
>Subject: [PATCH] netmap: Remove pointer printing in netmap_mem2.c
>
>There is no need to print the address of ifp
>every time when calling netmap_mem_pt_guest_ifp_del.
>This will leak the address of ifp to user space.
>
>Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
>---
> sys/dev/netmap/netmap_mem2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/sys/dev/netmap/netmap_mem2.c b/sys/dev/netmap/netmap_mem2.c
>index fc0b62d2abf..fd2b79b2b6b 100644
>--- a/sys/dev/netmap/netmap_mem2.c
>+++ b/sys/dev/netmap/netmap_mem2.c
>@@ -2446,8 +2446,8 @@ netmap_mem_pt_guest_ifp_del(struct netmap_mem_d *nmd, struct ifnet *ifp)
> 			} else {
> 				ptnmd->pt_ifs = curr->next;
> 			}
>-			nm_prinf("removed (ifp=%p,nifp_offset=%u)",
>-			  curr->ifp, curr->nifp_offset);
>+			nm_prinf("removed (nifp_offset=%u)",
>+			  curr->nifp_offset);
> 			nm_os_free(curr);
> 			ret = 0;
> 			break;
>-- 
>2.11.0
>

Actions: View | Diff

Attachments on bug 238641: 205162