FreeBSD Bugzilla – Attachment 215797 Details for
Bug 247431
sysutils/bsdisks: coredumps on postponed registration processing due to wrong iteration
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix iteration over postponed registrations set
patch-objectmanager.cpp (text/plain), 813 bytes, created by
Oleg Sidorkin
on 2020-06-19 20:01:22 UTC
(
hide
)
Description:
Fix iteration over postponed registrations set
Filename:
MIME Type:
Creator:
Oleg Sidorkin
Created:
2020-06-19 20:01:22 UTC
Size:
813 bytes
patch
obsolete
>--- objectmanager.cpp.orig 2020-05-23 16:59:10 UTC >+++ objectmanager.cpp >@@ -229,13 +229,15 @@ void ObjectManager::tryRegisterPostponed() > { > postponedSize = m_postponedRegistrations.size(); > >- for(auto it = m_postponedRegistrations.begin(); it != m_postponedRegistrations.end(); it++) >+ for(auto it = m_postponedRegistrations.cbegin(); it != m_postponedRegistrations.cend();) > { > if(registerBlock(m_blockObjects[*it], false)) > { > qDebug() << "Pop " << *it << " from m_postponedRegistrations"; >- m_postponedRegistrations.erase(it); >+ it = m_postponedRegistrations.erase(it); > } >+ else >+ ++it; > } > } while(postponedSize > m_postponedRegistrations.size()); > }
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=215797">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 247431
: 215797