Attachment 217546 Details for Bug 248934 – hw.em.sbp off by default

[patch] hw.em.sbp off by default

e1000-sbp-off.patch (text/plain), 1.08 KB, created by Franco Fichtner on 2020-08-26 18:00:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Franco Fichtner

Created: 2020-08-26 18:00:22 UTC

Size: 1.08 KB

patch

obsolete

>From f6c022798a9e4f374250c748adc4da5ac2b4a15e Mon Sep 17 00:00:00 2001
>From: Franco Fichtner <franco@opnsense.org>
>Date: Mon, 24 Aug 2020 09:28:15 +0200
>Subject: [PATCH] e1000: flip "show bad packets" back to where it was in
> version 11
>
>Was changed in the initial iflib conversion.  Currently the sysctl is
>still documented as such:
>
>    hw.em.sbp
>        Show bad packets when in promiscuous mode.  Default 0 (off).
>---
> sys/dev/e1000/if_em.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c
>index 3db75524963..6daccf001e7 100644
>--- a/sys/dev/e1000/if_em.c
>+++ b/sys/dev/e1000/if_em.c
>@@ -495,7 +495,7 @@ SYSCTL_INT(_hw_em, OID_AUTO, smart_pwr_down, CTLFLAG_RDTUN, &em_smart_pwr_down,
>     0, "Set to true to leave smart power down enabled on newer adapters");
> 
> /* Controls whether promiscuous also shows bad packets */
>-static int em_debug_sbp = TRUE;
>+static int em_debug_sbp = FALSE;
> SYSCTL_INT(_hw_em, OID_AUTO, sbp, CTLFLAG_RDTUN, &em_debug_sbp, 0,
>     "Show bad packets in promiscuous mode");
> 
>-- 
>2.21.0 (Apple Git-122.2)
>

Actions: View | Diff

Attachments on bug 248934: 217546