FreeBSD Bugzilla – Attachment 221214 Details for
Bug 252358
cp(1) of large files is causing 100% CPU utilization and poor transfer of ~168M/minute
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
fix the problem by using a large "len" argument for copy_file_range(2)
cp.patch (text/plain), 685 bytes, created by
Rick Macklem
on 2021-01-02 21:49:40 UTC
(
hide
)
Description:
fix the problem by using a large "len" argument for copy_file_range(2)
Filename:
MIME Type:
Creator:
Rick Macklem
Created:
2021-01-02 21:49:40 UTC
Size:
685 bytes
patch
obsolete
>--- bin/cp/utils.c.sav 2020-09-26 18:15:40.072631000 -0700 >+++ bin/cp/utils.c 2020-09-27 17:39:57.404325000 -0700 >@@ -77,7 +77,7 @@ __FBSDID("$FreeBSD: head/bin/cp/utils.c 365643 2020-09 > static int > copy_fallback(int from_fd, int to_fd, char *buf, size_t bufsize) > { >- int rcount; >+ ssize_t rcount; > ssize_t wresid, wcount = 0; > char *bufp; > >@@ -236,7 +236,7 @@ copy_file(const FTSENT *entp, int dne) > do { > if (use_copy_file_range) { > rcount = copy_file_range(from_fd, NULL, >- to_fd, NULL, bufsize, 0); >+ to_fd, NULL, SSIZE_MAX, 0); > if (rcount < 0 && errno == EINVAL) { > /* Prob a non-seekable FD */ > use_copy_file_range = 0;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 252358
:
221214
|
221230
|
221271