Added
Link Here
|
0 |
- |
1 |
From 0aead8cb868003a5dff2e81d6a7ffd7579652610 Mon Sep 17 00:00:00 2001 |
|
|
2 |
From: Fabian Keil <fk@fabiankeil.de> |
3 |
Date: Sun, 17 Jan 2021 11:21:59 +0100 |
4 |
Subject: [PATCH] wolfSSL_CertManagerFree(): free refMutex |
5 |
|
6 |
Fixes memory leaks like: |
7 |
==323== 96 bytes in 1 blocks are definitely lost in loss record 3 of 4 |
8 |
==323== at 0x4C291E1: calloc (in /usr/local/lib/valgrind/vgpreload_memcheck-amd64-freebsd.so) |
9 |
==323== by 0x585495F: pthread_mutex_init (in /lib/libthr.so.3) |
10 |
==323== by 0x4E7B5E8: wc_InitMutex (wc_port.c:1071) |
11 |
==323== by 0x4F09540: wolfSSL_CertManagerNew_ex (ssl.c:3596) |
12 |
==323== by 0x4EC6A81: InitSSL_Ctx (internal.c:1752) |
13 |
==323== by 0x4F0441E: wolfSSL_CTX_new_ex (ssl.c:394) |
14 |
==323== by 0x4F04658: wolfSSL_CTX_new (ssl.c:436) |
15 |
==323== by 0x400AA2: main (wolfssl-ctx-leak.c:9) |
16 |
|
17 |
This is a partial cherry-pick of upstream commit |
18 |
9598c037168b73ce2f by Tesfa Mael. |
19 |
--- |
20 |
src/ssl.c | 4 +++- |
21 |
1 file changed, 3 insertions(+), 1 deletion(-) |
22 |
|
23 |
diff --git src/ssl.c src/ssl.c |
24 |
index 19d36795e..9433d302e 100644 |
25 |
--- src/ssl.c |
26 |
+++ src/ssl.c |
27 |
@@ -3663,7 +3663,9 @@ void wolfSSL_CertManagerFree(WOLFSSL_CERT_MANAGER* cm) |
28 |
FreeTrustedPeerTable(cm->tpTable, TP_TABLE_SIZE, cm->heap); |
29 |
wc_FreeMutex(&cm->tpLock); |
30 |
#endif |
31 |
- |
32 |
+ if (wc_FreeMutex(&cm->refMutex) != 0) { |
33 |
+ WOLFSSL_MSG("Couldn't free refMutex mutex"); |
34 |
+ } |
35 |
XFREE(cm, cm->heap, DYNAMIC_TYPE_CERT_MANAGER); |
36 |
} |
37 |
} |
38 |
-- |
39 |
2.30.0 |
40 |
|