View | Details | Raw Unified | Return to bug 38631
Collapse All | Expand All

(-)article.sgml (-12 / +18 lines)
Lines 2422-2449 cvs add: use 'cvs commit' to add this fi Link Here
2422
		<row>
2422
		<row>
2423
		  <entry><literal>Submitted by:</literal></entry>
2423
		  <entry><literal>Submitted by:</literal></entry>
2424
		  <entry>The name and e-mail address of the person that
2424
		  <entry>The name and e-mail address of the person that
2425
		    submitted the fix.</entry>
2425
		    submitted the fix; for committers, just the username on
2426
		    the FreeBSD cluster.</entry>
2426
		</row>
2427
		</row>
2427
2428
2428
		<row>
2429
		<row>
2429
		  <entry><literal>Reviewed by:</literal></entry>
2430
		  <entry><literal>Reviewed by:</literal></entry>
2430
		  <entry>The name and e-mail address of the person or people
2431
		  <entry>The name and e-mail address of the person or people
2431
		    that reviewed the change.  If a patch was submitted to a
2432
		    that reviewed the change; for committers, just the
2432
		    mailing list for review, and the review was favorable,
2433
		    username on the FreeBSD cluster. If a patch was
2433
		    then just include the list name.</entry>
2434
		    submitted to a mailing list for review, and the review
2435
		    was favorable, then just include the list name.</entry>
2434
		</row>
2436
		</row>
2435
2437
2436
		<row>
2438
		<row>
2437
		  <entry><literal>Approved by:</literal></entry>
2439
		  <entry><literal>Approved by:</literal></entry>
2438
		  <entry>The name and e-mail address of the person or people
2440
		  <entry>The name and e-mail address of the person or people
2439
		    that approved the change.  It is customary to get prior
2441
		    that approved the change; for committers, just the
2440
		    approval for a commit if it is to an area of the tree to
2442
		    username on the FreeBSD cluster. It is customary to get
2441
		    which you do not usually commit.  In addition, during the
2443
		    prior approval for a commit if it is to an area of the
2442
		    run up to a new release all commits
2444
		    tree to which you do not usually commit.  In addition,
2443
		    <emphasis>must</emphasis> be approved by the release
2445
		    during the run up to a new release all commits
2444
		    engineer.  If these are your first commits then you should
2446
		    <emphasis>must</emphasis> be approved by the release
2445
		    have passed them past your mentor first for approval, and
2447
		    engineering team.  If these are your first commits then
2446
		    you should list your mentor.</entry>
2448
		    you should have passed them past your mentor first, and
2449
		    you should list your mentor, as in
2450
		    ``<replaceable>username-of-mentor</replaceable>
2451
		    <literal>(mentor)</literal>''.
2452
                 </entry>
2447
		</row>
2453
		</row>
2448
2454
2449
		<row>
2455
		<row>

Return to bug 38631