Attachment 22227 Details for Bug 38631 – file.diff

[patch] file.diff

file.diff (text/plain), 2.41 KB, created by pfeifer on 2002-05-27 21:50:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: pfeifer

Created: 2002-05-27 21:50:01 UTC

Size: 2.41 KB

patch

obsolete

>Index: article.sgml
>===================================================================
>RCS file: /home/ncvs/doc/en_US.ISO8859-1/articles/committers-guide/article.sgml,v
>retrieving revision 1.125
>diff -u -3 -p -r1.125 article.sgml
>--- article.sgml	26 May 2002 23:35:19 -0000	1.125
>+++ article.sgml	27 May 2002 20:30:13 -0000
>@@ -2422,28 +2422,34 @@ cvs add: use 'cvs commit' to add this fi
> 		<row>
> 		  <entry><literal>Submitted by:</literal></entry>
> 		  <entry>The name and e-mail address of the person that
>-		    submitted the fix.</entry>
>+		    submitted the fix; for committers, just the username on
>+		    the FreeBSD cluster.</entry>
> 		</row>
> 
> 		<row>
> 		  <entry><literal>Reviewed by:</literal></entry>
> 		  <entry>The name and e-mail address of the person or people
>-		    that reviewed the change.  If a patch was submitted to a
>-		    mailing list for review, and the review was favorable,
>-		    then just include the list name.</entry>
>+		    that reviewed the change; for committers, just the
>+		    username on the FreeBSD cluster. If a patch was
>+		    submitted to a mailing list for review, and the review
>+		    was favorable, then just include the list name.</entry>
> 		</row>
> 
> 		<row>
> 		  <entry><literal>Approved by:</literal></entry>
> 		  <entry>The name and e-mail address of the person or people
>-		    that approved the change.  It is customary to get prior
>-		    approval for a commit if it is to an area of the tree to
>-		    which you do not usually commit.  In addition, during the
>-		    run up to a new release all commits
>-		    <emphasis>must</emphasis> be approved by the release
>-		    engineer.  If these are your first commits then you should
>-		    have passed them past your mentor first for approval, and
>-		    you should list your mentor.</entry>
>+		    that approved the change; for committers, just the
>+		    username on the FreeBSD cluster. It is customary to get
>+		    prior approval for a commit if it is to an area of the
>+		    tree to which you do not usually commit.  In addition,
>+		    during the run up to a new release all commits
>+		    <emphasis>must</emphasis> be approved by the release
>+		    engineering team.  If these are your first commits then
>+		    you should have passed them past your mentor first, and
>+		    you should list your mentor, as in
>+		    ``<replaceable>username-of-mentor</replaceable>
>+		    <literal>(mentor)</literal>''.
>+                 </entry>
> 		</row>
> 
> 		<row>

Actions: View | Diff

Attachments on bug 38631: 22227